Skip to content

Commit 4153a0b

Browse files
committed
style: fix error [E302] - Expected 2 blank lines, found 1.
Used Ruff (vscode and pre-commit) to: - Black-compatible code formatting. - fix all auto-fixable violations. - isort-compatible import sorting. - flake8-simplify manual fixes. Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
1 parent afad207 commit 4153a0b

10 files changed

Lines changed: 88 additions & 41 deletions

File tree

src/instana/autoprofile/runtime.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
if TYPE_CHECKING:
1010
from types import FrameType
1111

12+
1213
class RuntimeInfo(object):
1314
OS_LINUX = sys.platform.startswith("linux")
1415
OS_DARWIN = sys.platform == "darwin"

src/instana/util/aws.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33

44
from ..log import logger
55

6+
67
def normalize_aws_lambda_arn(context):
78
"""
89
Parse the AWS Lambda context object for a fully qualified AWS Lambda function ARN.
@@ -15,12 +16,12 @@ def normalize_aws_lambda_arn(context):
1516
"""
1617
try:
1718
arn = context.invoked_function_arn
18-
parts = arn.split(':')
19+
parts = arn.split(":")
1920

2021
count = len(parts)
2122
if count == 7:
2223
# need to append version
23-
arn = arn + ':' + context.function_version
24+
arn = arn + ":" + context.function_version
2425
elif count != 8:
2526
logger.debug("Unexpected ARN parse issue: %s", arn)
2627

src/instana/util/gunicorn.py

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,9 @@
33

44
import os
55
import sys
6-
from ..log import logger
6+
7+
from instana.log import logger
8+
79

810
def running_in_gunicorn():
911
"""
@@ -15,22 +17,22 @@ def running_in_gunicorn():
1517

1618
try:
1719
# Is this a gunicorn process?
18-
if hasattr(sys, 'argv'):
20+
if hasattr(sys, "argv"):
1921
for arg in sys.argv:
20-
if arg.find('gunicorn') >= 0:
22+
if arg.find("gunicorn") >= 0:
2123
process_check = True
2224
elif os.path.isfile("/proc/self/cmdline"):
2325
with open("/proc/self/cmdline") as cmd:
2426
contents = cmd.read()
2527

26-
parts = contents.split('\0')
28+
parts = contents.split("\0")
2729
parts.pop()
2830
cmdline = " ".join(parts)
2931

30-
if cmdline.find('gunicorn') >= 0:
32+
if cmdline.find("gunicorn") >= 0:
3133
process_check = True
3234

3335
return process_check
3436
except Exception:
3537
logger.debug("Instana.log.running_in_gunicorn: ", exc_info=True)
36-
return False
38+
return False

src/instana/util/ids.py

Lines changed: 15 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,11 @@
66
import random
77
from typing import Union
88

9-
from opentelemetry.trace.span import _SPAN_ID_MAX_VALUE, INVALID_SPAN_ID, INVALID_TRACE_ID
9+
from opentelemetry.trace.span import (
10+
_SPAN_ID_MAX_VALUE,
11+
INVALID_SPAN_ID,
12+
INVALID_TRACE_ID,
13+
)
1014

1115
_rnd = random.Random()
1216
_current_pid = 0
@@ -39,7 +43,7 @@ def header_to_long_id(header: Union[bytes, str]) -> int:
3943
:return: a valid ID to be used internal to the tracer
4044
"""
4145
if isinstance(header, bytes):
42-
header = header.decode('utf-8')
46+
header = header.decode("utf-8")
4347

4448
if not isinstance(header, str):
4549
return INVALID_TRACE_ID
@@ -67,7 +71,7 @@ def header_to_id(header: Union[bytes, str]) -> int:
6771
:return: a valid ID to be used internal to the tracer
6872
"""
6973
if isinstance(header, bytes):
70-
header = header.decode('utf-8')
74+
header = header.decode("utf-8")
7175

7276
if not isinstance(header, str):
7377
return INVALID_SPAN_ID
@@ -103,13 +107,14 @@ def hex_id(id: Union[int, str]) -> str:
103107
elif length > 16 and length < 32:
104108
hex_id = hex_id.zfill(32)
105109
return hex_id
106-
except ValueError: # Handles ValueError: invalid literal for int() with base 10:
110+
except ValueError: # Handles ValueError: invalid literal for int() with base 10:
107111
return id
108112

113+
109114
def hex_id_limited(id: Union[int, str]) -> str:
110115
"""
111116
Returns the hexadecimal representation of the given ID.
112-
Limit longer IDs to 16 characters
117+
Limit longer IDs to 16 characters
113118
"""
114119
try:
115120
hex_id = hex(int(id))[2:]
@@ -121,9 +126,10 @@ def hex_id_limited(id: Union[int, str]) -> str:
121126
# Phase 0: Discard everything but the last 16byte
122127
hex_id = hex_id[-16:]
123128
return hex_id
124-
except ValueError: # Handles ValueError: invalid literal for int() with base 10:
129+
except ValueError: # Handles ValueError: invalid literal for int() with base 10:
125130
return id
126131

132+
127133
def define_server_timing(trace_id: Union[int, str]) -> str:
128134
# Note: The key `intid` is short for Instana Trace ID.
129135
return f"intid;desc={hex_id_limited(trace_id)}"
@@ -135,7 +141,7 @@ def internal_id(id: Union[int, str]) -> int:
135141
"""
136142
if isinstance(id, int):
137143
return id
138-
144+
139145
length = len(id)
140146

141147
if isinstance(id, str) and id.isdigit():
@@ -153,7 +159,8 @@ def internal_id(id: Union[int, str]) -> int:
153159
return int(id, 16)
154160
except ValueError:
155161
return INVALID_TRACE_ID
156-
162+
163+
157164
def internal_id_limited(id: Union[int, str]) -> int:
158165
"""
159166
Returns a valid id to be used internally. Handles both str and int types.

src/instana/util/sql.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,16 @@
33

44
import re
55

6+
67
def sql_sanitizer(sql):
78
"""
89
Removes values from valid SQL statements and returns a stripped version.
910
1011
:param sql: The SQL statement to be sanitized
1112
:return: String - A sanitized SQL statement without values.
1213
"""
13-
return regexp_sql_values.sub('?', sql)
14+
return regexp_sql_values.sub("?", sql)
1415

1516

1617
# Used by sql_sanitizer
17-
regexp_sql_values = re.compile(r"('[\s\S][^']*'|\d*\.\d+|\d+|NULL)")
18+
regexp_sql_values = re.compile(r"('[\s\S][^']*'|\d*\.\d+|\d+|NULL)")

tests/apps/bottle_app/app.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,23 +15,26 @@
1515
logger = logging.getLogger(__name__)
1616

1717
testenv["wsgi_port"] = 10812
18-
testenv["wsgi_server"] = ("http://127.0.0.1:" + str(testenv["wsgi_port"]))
18+
testenv["wsgi_server"] = "http://127.0.0.1:" + str(testenv["wsgi_port"])
1919

2020
app = default_app()
2121

22+
2223
@app.route("/")
2324
def hello():
2425
return "<center><h1>🐍 Hello Stan! 🦄</h1></center>"
2526

27+
2628
@app.route("/response_headers")
2729
def response_headers():
2830
response.set_header("X-Capture-This", "this")
2931
response.set_header("X-Capture-That", "that")
3032
return "Stan wuz here with headers!"
3133

34+
3235
# Wrap the application with the Instana WSGI Middleware
3336
app = InstanaWSGIMiddleware(app)
34-
bottle_server = make_server('127.0.0.1', testenv["wsgi_port"], app)
37+
bottle_server = make_server("127.0.0.1", testenv["wsgi_port"], app)
3538

3639
if __name__ == "__main__":
3740
bottle_server.request_queue_size = 20

tests/w3c_trace_context/test_traceparent.py

Lines changed: 31 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
import unittest
66
from instana.util.ids import header_to_long_id, header_to_id
77

8+
89
class TestTraceparent(unittest.TestCase):
910
def setUp(self):
1011
self.tp = Traceparent()
@@ -38,14 +39,18 @@ def test_validate_traceparent_None(self):
3839

3940
def test_get_traceparent_fields(self):
4041
traceparent = f"00-{self.w3cTraceId}-00f067aa0ba902b7-01"
41-
version, trace_id, parent_id, sampled_flag = self.tp.get_traceparent_fields(traceparent)
42+
version, trace_id, parent_id, sampled_flag = self.tp.get_traceparent_fields(
43+
traceparent
44+
)
4245
self.assertEqual(trace_id, header_to_long_id(self.w3cTraceId))
4346
self.assertEqual(parent_id, 67667974448284343)
4447
self.assertTrue(sampled_flag)
4548

4649
def test_get_traceparent_fields_unsampled(self):
4750
traceparent = f"00-{self.w3cTraceId}-00f067aa0ba902b7-00"
48-
version, trace_id, parent_id, sampled_flag = self.tp.get_traceparent_fields(traceparent)
51+
version, trace_id, parent_id, sampled_flag = self.tp.get_traceparent_fields(
52+
traceparent
53+
)
4954
self.assertEqual(trace_id, header_to_long_id(self.w3cTraceId))
5055
self.assertEqual(parent_id, 67667974448284343)
5156
self.assertFalse(sampled_flag)
@@ -54,28 +59,36 @@ def test_get_traceparent_fields_newer_version(self):
5459
# Although the incoming traceparent header sports a newer version number, we should still be able to parse the
5560
# parts that we understand (and consider it valid).
5661
traceparent = f"fe-{self.w3cTraceId}-00f067aa0ba902b7-01-12345-abcd"
57-
version, trace_id, parent_id, sampled_flag = self.tp.get_traceparent_fields(traceparent)
62+
version, trace_id, parent_id, sampled_flag = self.tp.get_traceparent_fields(
63+
traceparent
64+
)
5865
self.assertEqual(trace_id, header_to_long_id(self.w3cTraceId))
5966
self.assertEqual(parent_id, 67667974448284343)
6067
self.assertTrue(sampled_flag)
6168

6269
def test_get_traceparent_fields_unknown_flags(self):
6370
traceparent = f"00-{self.w3cTraceId}-00f067aa0ba902b7-ff"
64-
version, trace_id, parent_id, sampled_flag = self.tp.get_traceparent_fields(traceparent)
71+
version, trace_id, parent_id, sampled_flag = self.tp.get_traceparent_fields(
72+
traceparent
73+
)
6574
self.assertEqual(trace_id, header_to_long_id(self.w3cTraceId))
6675
self.assertEqual(parent_id, 67667974448284343)
6776
self.assertTrue(sampled_flag)
6877

6978
def test_get_traceparent_fields_None_input(self):
7079
traceparent = None
71-
version, trace_id, parent_id, sampled_flag = self.tp.get_traceparent_fields(traceparent)
80+
version, trace_id, parent_id, sampled_flag = self.tp.get_traceparent_fields(
81+
traceparent
82+
)
7283
self.assertIsNone(trace_id)
7384
self.assertIsNone(parent_id)
7485
self.assertFalse(sampled_flag)
7586

7687
def test_get_traceparent_fields_string_input_no_dash(self):
7788
traceparent = "invalid"
78-
version, trace_id, parent_id, sampled_flag = self.tp.get_traceparent_fields(traceparent)
89+
version, trace_id, parent_id, sampled_flag = self.tp.get_traceparent_fields(
90+
traceparent
91+
)
7992
self.assertIsNone(trace_id)
8093
self.assertIsNone(parent_id)
8194
self.assertFalse(sampled_flag)
@@ -86,12 +99,22 @@ def test_update_traceparent(self):
8699
in_span_id = "1234567890abcdef"
87100
level = 1
88101
expected_traceparent = "00-4bf92f3577b34da6a3ce929d0e0e4736-1234567890abcdef-01"
89-
self.assertEqual(expected_traceparent, self.tp.update_traceparent(traceparent, in_trace_id, header_to_id(in_span_id), level))
102+
self.assertEqual(
103+
expected_traceparent,
104+
self.tp.update_traceparent(
105+
traceparent, in_trace_id, header_to_id(in_span_id), level
106+
),
107+
)
90108

91109
def test_update_traceparent_None(self):
92110
traceparent = None
93111
in_trace_id = "1234d0e0e4736234"
94112
in_span_id = "7890abcdef"
95113
level = 0
96114
expected_traceparent = "00-00000000000000001234d0e0e4736234-0000007890abcdef-00"
97-
self.assertEqual(expected_traceparent, self.tp.update_traceparent(traceparent, in_trace_id, header_to_id(in_span_id), level))
115+
self.assertEqual(
116+
expected_traceparent,
117+
self.tp.update_traceparent(
118+
traceparent, in_trace_id, header_to_id(in_span_id), level
119+
),
120+
)

tests_autowrapt/test_autowrapt.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import os
22
import sys
33

4+
45
def test_autowrapt_bootstrap():
56
assert os.environ.get("AUTOWRAPT_BOOTSTRAP") == "instana"
67
assert "instana" in sys.modules

tests_aws/01_lambda/test_lambda.py

Lines changed: 15 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
if TYPE_CHECKING:
2525
from instana.span.span import InstanaSpan
2626

27+
2728
# Mock Context object
2829
class MockContext(dict):
2930
def __init__(self, **kwargs: Dict[str, Any]) -> None:
@@ -81,7 +82,7 @@ def _resource(self) -> Generator[None, None, None]:
8182
self.agent: AWSLambdaAgent = get_agent()
8283
yield
8384
# tearDown
84-
# Reset collector config
85+
# Reset collector config
8586
self.agent.collector.snapshot_data_sent = False
8687
# Reset all environment variables of consequence
8788
if "AWS_EXECUTION_ENV" in os.environ:
@@ -139,28 +140,28 @@ def test_get_handler(self) -> None:
139140
os.environ["LAMBDA_HANDLER"] = "tests.lambda_handler"
140141
handler_module, handler_function = get_aws_lambda_handler()
141142

142-
assert "tests" == handler_module
143-
assert "lambda_handler" == handler_function
143+
assert handler_module == "tests"
144+
assert handler_function == "lambda_handler"
144145

145146
def test_get_handler_with_multi_subpackages(self) -> None:
146147
os.environ["LAMBDA_HANDLER"] = "tests.one.two.three.lambda_handler"
147148
handler_module, handler_function = get_aws_lambda_handler()
148149

149-
assert "tests.one.two.three" == handler_module
150-
assert "lambda_handler" == handler_function
150+
assert handler_module == "tests.one.two.three"
151+
assert handler_function == "lambda_handler"
151152

152153
def test_get_handler_with_space_in_it(self) -> None:
153154
os.environ["LAMBDA_HANDLER"] = " tests.another_module.lambda_handler"
154155
handler_module, handler_function = get_aws_lambda_handler()
155156

156-
assert "tests.another_module" == handler_module
157-
assert "lambda_handler" == handler_function
157+
assert handler_module == "tests.another_module"
158+
assert handler_function == "lambda_handler"
158159

159160
os.environ["LAMBDA_HANDLER"] = "tests.another_module.lambda_handler "
160161
handler_module, handler_function = get_aws_lambda_handler()
161162

162-
assert "tests.another_module" == handler_module
163-
assert "lambda_handler" == handler_function
163+
assert handler_module == "tests.another_module"
164+
assert handler_function == "lambda_handler"
164165

165166
def test_agent_extra_http_headers(self) -> None:
166167
os.environ["INSTANA_EXTRA_HTTP_HEADERS"] = (
@@ -184,7 +185,7 @@ def test_custom_service_name(self, trace_id: int, span_id: int) -> None:
184185
os.environ["INSTANA_AGENT_KEY"] = "Fake_Key"
185186
# We need reset the AWSLambdaOptions with new INSTANA_SERVICE_NAME
186187
self.agent.options = AWSLambdaOptions()
187-
188+
188189
with open(
189190
self.pwd + "/../data/lambda/api_gateway_event.json", "r"
190191
) as json_file:
@@ -779,7 +780,9 @@ def test_arn_parsing(self) -> None:
779780
def test_agent_default_log_level(self) -> None:
780781
assert self.agent.options.log_level == logging.WARNING
781782

782-
def __validate_result_and_payload_for_gateway_v2_trace(self, result: Dict[str, Any], payload: defaultdict) -> "InstanaSpan":
783+
def __validate_result_and_payload_for_gateway_v2_trace(
784+
self, result: Dict[str, Any], payload: defaultdict
785+
) -> "InstanaSpan":
783786
assert isinstance(result, dict)
784787
assert "headers" in result
785788
assert "Server-Timing" in result["headers"]
@@ -835,4 +838,4 @@ def __validate_result_and_payload_for_gateway_v2_trace(self, result: Dict[str, A
835838
assert span.data["http"]["path_tpl"] == "/my/{resource}"
836839
assert span.data["http"]["params"] == "secret=key&q=term"
837840

838-
return span
841+
return span

0 commit comments

Comments
 (0)