style: fix error [SIM300] - Yoda condition detected.

Used Ruff (vscode and pre-commit) to:
- Black-compatible code formatting.
- fix all auto-fixable violations.
- isort-compatible import sorting.
- flake8-simplify manual fixes.

Signed-off-by: Paulo Vital <paulo.vital@ibm.com>

Author: pvital

src/instana/instrumentation/aiohttp/client.py

@@ -65,7 +65,7 @@ async def stan_request_end(
 
                 extract_custom_headers(span, params.response.headers)
 
-                if 500 <= params.response.status:
+                if params.response.status >= 500:
                     span.mark_as_errored({"http.error": params.response.reason})
 
                 if span.is_recording():

src/instana/instrumentation/asgi.py

@@ -17,6 +17,7 @@
 
 if TYPE_CHECKING:
     from starlette.middleware.exceptions import ExceptionMiddleware
+
     from instana.span.span import InstanaSpan
 
 
@@ -34,7 +35,7 @@ def _collect_kvs(self, scope: Dict[str, Any], span: "InstanaSpan") -> None:
             span.set_attribute(SpanAttributes.HTTP_METHOD, scope.get("method"))
 
             server = scope.get("server")
-            if isinstance(server, tuple) or isinstance(server, list):
+            if isinstance(server, (tuple, list)):
                 span.set_attribute(SpanAttributes.HTTP_HOST, server[0])
 
             query = scope.get("query_string")
@@ -102,7 +103,7 @@ async def send_wrapper(response: Dict[str, Any]) -> Awaitable[None]:
                 try:
                     status_code = response.get("status")
                     if status_code:
-                        if 500 <= int(status_code):
+                        if int(status_code) >= 500:
                             current_span.mark_as_errored()
                         current_span.set_attribute(
                             SpanAttributes.HTTP_STATUS_CODE, status_code

src/instana/instrumentation/aws/lambda_inst.py

@@ -55,7 +55,7 @@ def lambda_handler_with_instana(
                     if "statusCode" in result and result.get("statusCode"):
                         status_code = int(result["statusCode"])
                         span.set_attribute(SpanAttributes.HTTP_STATUS_CODE, status_code)
-                        if 500 <= status_code:
+                        if status_code >= 500:
                             span.record_exception(f"HTTP status {status_code}")
             except Exception as exc:
                 logger.debug(f"AWS Lambda lambda_handler_with_instana error: {exc}")

src/instana/instrumentation/django/middleware.py

@@ -94,7 +94,7 @@ def process_response(
         ) -> "HttpResponse":
             try:
                 if request.span:
-                    if 500 <= response.status_code:
+                    if response.status_code >= 500:
                         request.span.assure_errored()
                     # for django >= 2.2
                     if request.resolver_match is not None and hasattr(

src/instana/instrumentation/flask/common.py

@@ -82,7 +82,7 @@ def handle_user_exception_with_instana(
                     else:
                         status_code = response.status_code
 
-                if 500 <= status_code:
+                if status_code >= 500:
                     span.record_exception(exc)
 
                 span.set_attribute(SpanAttributes.HTTP_STATUS_CODE, int(status_code))
@@ -147,7 +147,7 @@ def inject_span(
 
         span = flask.g.span
         if span:
-            if 500 <= response.status_code:
+            if response.status_code >= 500:
                 span.mark_as_errored()
 
             span.set_attribute(

src/instana/instrumentation/httpx.py

@@ -58,7 +58,7 @@ def _set_response_span_attributes(
 
             status_code = response.status_code
             span.set_attribute(SpanAttributes.HTTP_STATUS_CODE, status_code)
-            if 500 <= status_code:
+            if status_code >= 500:
                 span.mark_as_errored()
         except Exception:
             logger.debug("httpx _set_request_span_attributes error: ", exc_info=True)

src/instana/instrumentation/sanic.py

@@ -92,7 +92,7 @@ def exception_with_instana(request: Request, exception: Exception) -> None:
                     status_code = exception.status_code
                     message = str(exception)
 
-                    if all([span, status_code, message]) and 500 <= status_code:
+                    if all([span, status_code, message]) and status_code >= 500:
                         span.set_attribute("http.error", message)
             except Exception:
                 logger.debug("exception_with_instana: ", exc_info=True)

src/instana/instrumentation/tornado/server.py

@@ -96,7 +96,7 @@ def on_finish_with_instana(
             status_code = instance.get_status()
 
             # Mark 500 responses as errored
-            if 500 <= status_code:
+            if status_code >= 500:
                 span.mark_as_errored()
 
             span.set_attribute(SpanAttributes.HTTP_STATUS_CODE, status_code)

src/instana/instrumentation/urllib3.py

@@ -55,7 +55,7 @@ def _collect_kvs(
 
             # Only construct URL if host is not None
             if kvs.get("host") and kvs.get("path"):
-                url = f'{kvs["host"]}:{kvs["port"]}{kvs["path"]}'
+                url = f"{kvs['host']}:{kvs['port']}{kvs['path']}"
                 if isinstance(instance, urllib3.connectionpool.HTTPSConnectionPool):
                     kvs["url"] = f"https://{url}"
                 else:
@@ -74,7 +74,7 @@ def collect_response(
 
             extract_custom_headers(span, response.headers)
 
-            if 500 <= response.status:
+            if response.status >= 500:
                 span.mark_as_errored()
         except Exception:
             logger.debug("urllib3 collect_response error: ", exc_info=True)

src/instana/instrumentation/wsgi.py

@@ -62,7 +62,7 @@ def new_start_response(
 
             # Set status code attribute
             sc = status.split(" ")[0]
-            if 500 <= int(sc):
+            if int(sc) >= 500:
                 span.mark_as_errored()
 
             span.set_attribute(SpanAttributes.HTTP_STATUS_CODE, sc)