Skip to content

Commit 797fc0b

Browse files
rdhyeeclaude
andauthored
Align Architecture & Vocabularies sidebar with Figma wireframe (#108)
- Rename section "Architecture and Vocabularies" → "Architecture & Vocabularies" - Add explicit text labels: Overview, Requirements, Schema, Vocabularies (was showing raw file titles like "iSamples Vocabularies") - Rename "Metadata Model" → "Schema" to match wireframe - Add TestSidebarArchitectureVocabularies test class (4 tests) - Update existing test to match "&" in section name Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 3ae6183 commit 797fc0b

2 files changed

Lines changed: 33 additions & 6 deletions

File tree

_quarto.yml

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -87,13 +87,16 @@ website:
8787
href: "about.qmd#photo-gallery"
8888
- text: "Background & History"
8989
href: "about.qmd#background-history"
90-
- section: "Architecture and Vocabularies"
90+
- section: "Architecture & Vocabularies"
9191
contents:
92-
- design/index.qmd
93-
- design/requirements.md
94-
- text: Metadata Model
92+
- href: design/index.qmd
93+
text: Overview
94+
- href: design/requirements.md
95+
text: Requirements
96+
- text: Schema
9597
href: "https://isamplesorg.github.io/metadata/"
96-
- models/index.qmd
98+
- href: models/index.qmd
99+
text: Vocabularies
97100
- section: "Research & Resources"
98101
contents:
99102
- text: Publications & Conferences

tests/test_navigation.py

Lines changed: 25 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ class TestSidebarSections:
1414
def test_sidebar_shows_architecture_and_vocabularies(self, page):
1515
page.goto(f"{SITE_URL}/about.html", wait_until="domcontentloaded")
1616
sidebar = page.locator(".sidebar-navigation")
17-
assert sidebar.get_by_text("Architecture and Vocabularies").count() > 0
17+
assert sidebar.get_by_text("Architecture & Vocabularies").count() > 0
1818

1919
def test_sidebar_does_not_show_old_information_architecture(self, page):
2020
page.goto(f"{SITE_URL}/about.html", wait_until="domcontentloaded")
@@ -94,6 +94,30 @@ def test_about_has_background_history(self, page):
9494
assert sidebar.get_by_text("Background & History").count() > 0
9595

9696

97+
class TestSidebarArchitectureVocabularies:
98+
"""Architecture & Vocabularies should have 4 items matching wireframe."""
99+
100+
def test_has_overview(self, page):
101+
page.goto(f"{SITE_URL}/design/index.html", wait_until="domcontentloaded")
102+
sidebar = page.locator(".sidebar-navigation")
103+
assert sidebar.get_by_text("Overview", exact=True).count() > 0
104+
105+
def test_has_requirements(self, page):
106+
page.goto(f"{SITE_URL}/design/index.html", wait_until="domcontentloaded")
107+
sidebar = page.locator(".sidebar-navigation")
108+
assert sidebar.get_by_text("Requirements", exact=True).count() > 0
109+
110+
def test_has_schema(self, page):
111+
page.goto(f"{SITE_URL}/design/index.html", wait_until="domcontentloaded")
112+
sidebar = page.locator(".sidebar-navigation")
113+
assert sidebar.get_by_text("Schema", exact=True).count() > 0
114+
115+
def test_has_vocabularies(self, page):
116+
page.goto(f"{SITE_URL}/design/index.html", wait_until="domcontentloaded")
117+
sidebar = page.locator(".sidebar-navigation")
118+
assert sidebar.get_by_text("Vocabularies", exact=True).count() > 0
119+
120+
97121
class TestSidebarResearchResources:
98122
"""Research & Resources should have 3 items matching wireframe."""
99123

0 commit comments

Comments
 (0)