Merge branch 'master' of github.com:joomla-framework/github-api into 2.0-dev

Author: mbabker

.travis.yml

@@ -22,7 +22,6 @@ matrix:
     - php: 7.2
     - php: nightly
   allow_failures:
-    - php: 7.2
     - php: nightly
 
 before_script:

src/AbstractGithubObject.php

@@ -86,7 +86,7 @@ public function __construct(Registry $options = null, Http $client = null)
 		$this->options = $options ?: new Registry;
 		$this->client = $client ?: (new HttpFactory)->getHttp($this->options);
 
-		$this->package = get_class($this);
+		$this->package = \get_class($this);
 		$this->package = substr($this->package, strrpos($this->package, '\\') + 1);
 	}
 

src/AbstractPackage.php

@@ -30,7 +30,7 @@ public function __construct(Registry $options = null, Http $client = null)
 	{
 		parent::__construct($options, $client);
 
-		$this->package = get_class($this);
+		$this->package = \get_class($this);
 		$this->package = substr($this->package, strrpos($this->package, '\\') + 1);
 	}
 

src/Package/Activity/Starring.php

@@ -58,7 +58,7 @@ public function getRepositories($user = '', $sort = 'created', $direction = 'des
 		$allowedSort = array('created', 'updated');
 		$allowedDir  = array('asc', 'desc');
 
-		if (!in_array($sort, $allowedSort))
+		if (!\in_array($sort, $allowedSort))
 		{
 			throw new \InvalidArgumentException(
 				sprintf(
@@ -68,7 +68,7 @@ public function getRepositories($user = '', $sort = 'created', $direction = 'des
 			);
 		}
 
-		if (!in_array($direction, $allowedDir))
+		if (!\in_array($direction, $allowedDir))
 		{
 			throw new \InvalidArgumentException(
 				sprintf(

src/Package/Issues.php

@@ -61,7 +61,7 @@ public function create($user, $repo, $title, $body = null, $assignee = null, $mi
 			'body'      => $body
 		);
 
-		if (is_string($assignee) && !empty($assignees))
+		if (\is_string($assignee) && !empty($assignees))
 		{
 			throw new \UnexpectedValueException('You cannot pass both assignee and assignees. Only one may be provided.');
 		}
@@ -70,7 +70,7 @@ public function create($user, $repo, $title, $body = null, $assignee = null, $mi
 		{
 			$data['assignees'] = array_values($assignees);
 		}
-		elseif (is_string($assignee))
+		elseif (\is_string($assignee))
 		{
 			$data['assignee'] = $assignee;
 		}

src/Package/Issues/Comments.php

@@ -73,7 +73,7 @@ public function getRepositoryList($owner, $repo, $sort = 'created', $direction =
 		// Build the request path.
 		$path = '/repos/' . $owner . '/' . $repo . '/issues/comments';
 
-		if (false == in_array($sort, array('created', 'updated')))
+		if (false == \in_array($sort, array('created', 'updated')))
 		{
 			throw new \UnexpectedValueException(
 				sprintf(
@@ -82,7 +82,7 @@ public function getRepositoryList($owner, $repo, $sort = 'created', $direction =
 			);
 		}
 
-		if (false == in_array($direction, array('asc', 'desc')))
+		if (false == \in_array($direction, array('asc', 'desc')))
 		{
 			throw new \UnexpectedValueException(
 				sprintf(

src/Package/Issues/Milestones.php

@@ -96,17 +96,17 @@ public function create($user, $repo, $title, $state = null, $description = null,
 			'title' => $title
 		);
 
-		if (!is_null($state))
+		if (!\is_null($state))
 		{
 			$data['state'] = $state;
 		}
 
-		if (!is_null($description))
+		if (!\is_null($description))
 		{
 			$data['description'] = $description;
 		}
 
-		if (!is_null($dueOn))
+		if (!\is_null($dueOn))
 		{
 			$data['due_on'] = $dueOn;
 		}
@@ -142,22 +142,22 @@ public function edit($user, $repo, $milestoneId, $title = null, $state = null, $
 		// Build the request data.
 		$data = array();
 
-		if (!is_null($title))
+		if (!\is_null($title))
 		{
 			$data['title'] = $title;
 		}
 
-		if (!is_null($state))
+		if (!\is_null($state))
 		{
 			$data['state'] = $state;
 		}
 
-		if (!is_null($description))
+		if (!\is_null($description))
 		{
 			$data['description'] = $description;
 		}
 
-		if (!is_null($dueOn))
+		if (!\is_null($dueOn))
 		{
 			$data['due_on'] = $dueOn;
 		}

src/Package/Markdown.php

@@ -39,7 +39,7 @@ public function render($text, $mode = 'gfm', $context = null)
 		$validModes = array('gfm', 'markdown');
 
 		// Make sure the scope is valid
-		if (!in_array($mode, $validModes))
+		if (!\in_array($mode, $validModes))
 		{
 			throw new \InvalidArgumentException(sprintf('The %s mode is not valid. Valid modes are "gfm" or "markdown".', $mode));
 		}

src/Package/Orgs.php

@@ -90,7 +90,7 @@ public function edit($org, $billingEmail = '', $company = '', $email = '', $loca
 
 		$data = array();
 
-		$fArgs = func_get_args();
+		$fArgs = \func_get_args();
 
 		foreach ($args as $i => $arg)
 		{

src/Package/Orgs/Hooks.php

@@ -85,7 +85,7 @@ public function create($org, $url, $contentType = 'form', $secret = null, $insec
 		// Build the request path.
 		$path = "/orgs/$org/hooks";
 
-		if (false == in_array($contentType, array('form', 'json')))
+		if (false == \in_array($contentType, array('form', 'json')))
 		{
 			throw new \UnexpectedValueException('Content type must be either "form" or "json".');
 		}
@@ -112,7 +112,7 @@ public function create($org, $url, $contentType = 'form', $secret = null, $insec
 			// Check to ensure all events are in the allowed list
 			foreach ($events as $event)
 			{
-				if (!in_array($event, $this->hookEvents))
+				if (!\in_array($event, $this->hookEvents))
 				{
 					throw new \RuntimeException('Your events array contains an unauthorized event.');
 				}
@@ -157,7 +157,7 @@ public function edit($org, $url, $contentType = null, $secret = null, $insecureS
 
 		if ($contentType)
 		{
-			if (false == in_array($contentType, array('form', 'json')))
+			if (false == \in_array($contentType, array('form', 'json')))
 			{
 				throw new \UnexpectedValueException('Content type must be either "form" or "json".');
 			}
@@ -189,7 +189,7 @@ public function edit($org, $url, $contentType = null, $secret = null, $insecureS
 			// Check to ensure all events are in the allowed list
 			foreach ($events as $event)
 			{
-				if (!in_array($event, $this->hookEvents))
+				if (!\in_array($event, $this->hookEvents))
 				{
 					throw new \RuntimeException('Your events array contains an unauthorized event.');
 				}