Skip to content

Commit 42672a8

Browse files
committed
[test] Remove old servlet API < 3 support code
(cherry picked from commit 676f521)
1 parent 4581f4e commit 42672a8

3 files changed

Lines changed: 3 additions & 39 deletions

File tree

src/spec/ruby/rack/handler/servlet_spec.rb

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -901,22 +901,7 @@ def servlet.create_env(servlet_env)
901901
env = servlet.create_env @servlet_env
902902

903903
expect(env['java.servlet_context']).to_not be nil
904-
if servlet_30?
905-
expect(env['java.servlet_context']).to be @servlet_context
906-
else
907-
expect(env['java.servlet_context']).to be @rack_context
908-
909-
# HACK to emulate Servlet API 3.0 MockHttpServletRequest has getServletContext :
910-
env = Rack::Handler::Servlet::DefaultEnv.new(@servlet_request).to_hash
911-
912-
expect(env['java.servlet_context']).to_not be nil
913-
expect(env['java.servlet_context']).to be @servlet_context
914-
begin
915-
expect(env['java.servlet_context']).to eq @servlet_context
916-
rescue NoMethodError
917-
expect((env['java.servlet_context'] == @servlet_context)).to eq true
918-
end
919-
end
904+
expect(env['java.servlet_context']).to be @servlet_context
920905
end
921906

922907
it "returns the servlet request when queried with java.servlet_request" do

src/spec/ruby/rack/servlet/response_capture_spec.rb

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,6 @@
7676
end
7777

7878
it "is considered handled when more than Allow header is added with OPTIONS" do
79-
pending "need Servlet API 3.0" unless servlet_30?
80-
8179
servlet_request.method = 'OPTIONS'
8280

8381
response_capture.setIntHeader "Answer", 42
@@ -87,8 +85,6 @@
8785
end
8886

8987
it "is considered handled when header is added" do
90-
pending "need Servlet API 3.0" unless servlet_30?
91-
9288
servlet_request.method = 'OPTIONS'
9389

9490
response_capture.addHeader "Hello", "World"

src/spec/ruby/spec_helper.rb

Lines changed: 2 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@
1616

1717
require 'rspec'
1818

19-
require 'jruby'; ext_class = org.jruby.rack.ext.RackLibrary
20-
JRuby.runtime.loadExtension 'JRuby::Rack', ext_class.new, true
19+
require 'jruby' # we rely on JRuby.runtime in a few places
20+
JRuby::Util.load_ext('org.jruby.rack.ext.RackLibrary')
2121

2222
module SharedHelpers
2323

@@ -54,23 +54,6 @@ def silence_warnings(&block)
5454
JRuby::Rack::Helpers.silence_warnings(&block)
5555
end
5656

57-
@@servlet_30 = nil
58-
59-
def servlet_30?
60-
return @@servlet_30 unless @@servlet_30.nil?
61-
@@servlet_30 = !!(Java::javax.servlet.AsyncContext rescue nil)
62-
end
63-
64-
private :servlet_30?
65-
66-
def rack_release(at_least = nil)
67-
require 'rack'; release = Rack.release
68-
release = '1.6' if Gem.loaded_specs['rack'].version.to_s == '1.6.0'
69-
at_least.nil? ? release : release >= at_least
70-
end
71-
72-
private :rack_release
73-
7457
def raise_logger(level = 'WARN')
7558
org.jruby.rack.logging.RaiseLogger.new(level, JRuby.runtime.out)
7659
end

0 commit comments

Comments
 (0)