Check an empty string #44

junichi11 · junichi11 · commit 503d0c5d95e6 · 2016-09-13T12:56:14.000+09:00
- If a custom query value is empty, don't add it
diff --git a/src/main/java/com/junichi11/netbeans/modules/github/issues/egit/SearchIssuesParams.java b/src/main/java/com/junichi11/netbeans/modules/github/issues/egit/SearchIssuesParams.java
@@ -246,7 +246,7 @@ public SearchIssuesParams milestone(Milestone milestone) {
     }
 
     public SearchIssuesParams milestone(String milestone) {
-        if (milestone != null) {
+        if (!StringUtils.isEmpty(milestone)) {
             qParameters.add(Pair.of("milestone", milestone)); // NOI18N
         }
         return this;

Original file line number	Diff line number	Diff line change
`@@ -246,7 +246,7 @@ public SearchIssuesParams milestone(Milestone milestone) {`
`246`	`246`	`}`
`247`	`247`
`248`	`248`	`public SearchIssuesParams milestone(String milestone) {`
`249`		`- if (milestone != null) {`
	`249`	`+ if (!StringUtils.isEmpty(milestone)) {`
`250`	`250`	`qParameters.add(Pair.of("milestone", milestone)); // NOI18N`
`251`	`251`	`}`
`252`	`252`	`return this;`