Skip to content

Commit e92cffc

Browse files
committed
Merge branch 'nb82'
2 parents f59857a + 8aaa3c2 commit e92cffc

4 files changed

Lines changed: 19 additions & 11 deletions

File tree

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<modelVersion>4.0.0</modelVersion>
44
<groupId>com.junichi11</groupId>
55
<artifactId>netbeans-github-issues</artifactId>
6-
<version>0.3.1</version>
6+
<version>0.3.2</version>
77
<packaging>nbm</packaging>
88
<build>
99
<plugins>

src/main/java/com/junichi11/netbeans/modules/github/issues/issue/ui/FileChangedPanel.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -227,8 +227,8 @@ public void run() {
227227
String mimeType = getMimeType(filename);
228228

229229
String prSha = file.getSha();
230-
StreamSource prSource = StreamSource.createSource(filename, prSha, mimeType, prReader); // NOI18N
231-
StreamSource baseSource = StreamSource.createSource(filename, baseSha, mimeType, baseReader); // NOI18N
230+
StreamSource prSource = StreamSource.createSource(filename, prSha, mimeType, prReader);
231+
StreamSource baseSource = StreamSource.createSource(filename, baseSha, mimeType, baseReader);
232232
final DiffView view = Diff.getDefault().createDiff(baseSource, prSource);
233233
SwingUtilities.invokeLater(new Runnable() {
234234
@Override

src/main/java/com/junichi11/netbeans/modules/github/issues/issue/ui/GitHubIssuePanel.java

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -439,13 +439,15 @@ public void update() {
439439
List<CommitFile> pullRequestsFiles = repository.getPullRequestsFiles(issue.getNumber());
440440
filesChangedPanel.setDisplayName(String.format("[Diff] #%s - %s", id, summary)); // NOI18N
441441
filesChangedPanel.removeAllFiles();
442-
String hostname = repository.getHostname();
443-
for (CommitFile file : pullRequestsFiles) {
444-
if (hostname.equals(GitHubIssues.DEFAULT_HOSTNAME)) {
445-
hostname = IGitHubConstants.HOST_DEFAULT;
446-
}
447-
filesChangedPanel.addFile(file, base, hostname);
448-
}
442+
// #51 disable each file diff
443+
// FIXME if we can get exact sha ids, this can be enabled again
444+
// String hostname = repository.getHostname();
445+
// for (CommitFile file : pullRequestsFiles) {
446+
// if (hostname.equals(GitHubIssues.DEFAULT_HOSTNAME)) {
447+
// hostname = IGitHubConstants.HOST_DEFAULT;
448+
// }
449+
// filesChangedPanel.addFile(file, base, hostname);
450+
// }
449451
filesChangedPanel.setDetails(pullRequest);
450452
filesChangedcollapsibleSectionPanel.setLabel(Bundle.GitHubIssuePanel_files_changed_count(pullRequestsFiles.size()));
451453

src/main/java/com/junichi11/netbeans/modules/github/issues/repository/GitHubRepository.java

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@
4343

4444
import com.junichi11.netbeans.modules.github.issues.GitHubCache;
4545
import com.junichi11.netbeans.modules.github.issues.GitHubIcons;
46+
import com.junichi11.netbeans.modules.github.issues.GitHubIssues;
4647
import com.junichi11.netbeans.modules.github.issues.GitHubIssuesConfig;
4748
import com.junichi11.netbeans.modules.github.issues.GitHubIssuesConnector;
4849
import com.junichi11.netbeans.modules.github.issues.egit.SearchIssuesParams;
@@ -83,6 +84,7 @@
8384
import org.eclipse.egit.github.core.RepositoryCommitCompare;
8485
import org.eclipse.egit.github.core.User;
8586
import org.eclipse.egit.github.core.client.GitHubClient;
87+
import org.eclipse.egit.github.core.client.IGitHubConstants;
8688
import org.eclipse.egit.github.core.service.CollaboratorService;
8789
import org.eclipse.egit.github.core.service.CommitService;
8890
import org.eclipse.egit.github.core.service.IssueService;
@@ -1005,7 +1007,11 @@ public Repository getRepository() {
10051007
}
10061008

10071009
public void setRepositoryInfo(GitHubRepositoryInfo githubRepositoryInfo) {
1008-
String url = String.format("https://%s/%s/%s/issues/", githubRepositoryInfo.getHostname(), githubRepositoryInfo.getRepositoryAuthor(), githubRepositoryInfo.getRepositoryName()); // NOI18N
1010+
String hostname = githubRepositoryInfo.getHostname();
1011+
if (hostname.equals(GitHubIssues.DEFAULT_HOSTNAME)) {
1012+
hostname = IGitHubConstants.HOST_DEFAULT;
1013+
}
1014+
String url = String.format("https://%s/%s/%s/issues/", hostname, githubRepositoryInfo.getRepositoryAuthor(), githubRepositoryInfo.getRepositoryName()); // NOI18N
10091015
repositoryInfo = createRepositoryInfo(githubRepositoryInfo, url, githubRepositoryInfo.getUserName(), null, null, null);
10101016
setProperties(githubRepositoryInfo);
10111017
}

0 commit comments

Comments
 (0)