Skip to content

Commit dc580fc

Browse files
committed
Ignore ExtractCommentTags deprecation
Signed-off-by: Nelo-T. Wallus <n.wallus@sap.com>
1 parent 3f86d0f commit dc580fc

5 files changed

Lines changed: 7 additions & 7 deletions

File tree

cmd/cluster-client-gen/generators/client_generator.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -284,7 +284,7 @@ func applyGroupOverrides(universe types.Universe, args *args.Args) {
284284
changes := make(map[clientgentypes.GroupVersion]clientgentypes.GroupVersion)
285285
for gv, inputDir := range args.GroupVersionPackages() {
286286
p := universe.Package(inputDir)
287-
if override := gengo.ExtractCommentTags("+", p.Comments)["groupName"]; override != nil {
287+
if override := gengo.ExtractCommentTags("+", p.Comments)["groupName"]; override != nil { //nolint:staticcheck
288288
newGV := clientgentypes.GroupVersion{
289289
Group: clientgentypes.Group(override[0]),
290290
Version: gv.Version,
@@ -367,7 +367,7 @@ func GetTargets(context *generator.Context, args *args.Args) []generator.Target
367367
// If there's a comment of the form "// +groupGoName=SomeUniqueShortName", use that as
368368
// the Go group identifier in CamelCase. It defaults
369369
groupGoNames[gv] = namer.IC(strings.Split(gv.Group.NonEmpty(), ".")[0])
370-
if override := gengo.ExtractCommentTags("+", p.Comments)["groupGoName"]; override != nil {
370+
if override := gengo.ExtractCommentTags("+", p.Comments)["groupGoName"]; override != nil { //nolint:staticcheck
371371
groupGoNames[gv] = namer.IC(override[0])
372372
}
373373

cmd/cluster-client-gen/generators/generator_for_group.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ func (g *genGroup) GenerateType(c *generator.Context, t *types.Type, w io.Writer
7676
// allow user to define a group name that's different from the one parsed from the directory.
7777
p := c.Universe.Package(g.inputPackage)
7878
groupName := g.group
79-
if override := gengo.ExtractCommentTags("+", p.Comments)["groupName"]; override != nil {
79+
if override := gengo.ExtractCommentTags("+", p.Comments)["groupName"]; override != nil { //nolint:staticcheck
8080
groupName = override[0]
8181
}
8282

cmd/cluster-client-gen/generators/util/tags.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ func MustParseClientGenTags(lines []string) Tags {
193193
// tags are provided.
194194
func ParseClientGenTags(lines []string) (Tags, error) {
195195
ret := Tags{}
196-
values := gengo.ExtractCommentTags("+", lines)
196+
values := gengo.ExtractCommentTags("+", lines) //nolint:staticcheck
197197
var value []string
198198
value, ret.GenerateClient = values["genclient"]
199199
// Check the old format and error when used to avoid generating client when //+genclient=false

cmd/cluster-informer-gen/generators/targets.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -131,14 +131,14 @@ func GetTargets(context *generator.Context, args *args.Args) []generator.Target
131131
// If there's a comment of the form "// +groupName=somegroup" or
132132
// "// +groupName=somegroup.foo.bar.io", use the first field (somegroup) as the name of the
133133
// group when generating.
134-
if override := gengo.ExtractCommentTags("+", pkg.Comments)["groupName"]; override != nil {
134+
if override := gengo.ExtractCommentTags("+", pkg.Comments)["groupName"]; override != nil { //nolint:staticcheck
135135
gv.Group = clientgentypes.Group(override[0])
136136
}
137137

138138
// If there's a comment of the form "// +groupGoName=SomeUniqueShortName", use that as
139139
// the Go group identifier in CamelCase. It defaults
140140
groupGoNames[groupPkgName] = namer.IC(strings.Split(gv.Group.NonEmpty(), ".")[0])
141-
if override := gengo.ExtractCommentTags("+", pkg.Comments)["groupGoName"]; override != nil {
141+
if override := gengo.ExtractCommentTags("+", pkg.Comments)["groupGoName"]; override != nil { //nolint:staticcheck
142142
groupGoNames[groupPkgName] = namer.IC(override[0])
143143
}
144144

cmd/cluster-lister-gen/generators/lister.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ func GetTargets(context *generator.Context, args *args.Args) []generator.Target
9999
// If there's a comment of the form "// +groupName=somegroup" or
100100
// "// +groupName=somegroup.foo.bar.io", use the first field (somegroup) as the name of the
101101
// group when generating.
102-
if override := gengo.ExtractCommentTags("+", p.Comments)["groupName"]; override != nil {
102+
if override := gengo.ExtractCommentTags("+", p.Comments)["groupName"]; override != nil { //nolint:staticcheck
103103
gv.Group = clientgentypes.Group(strings.SplitN(override[0], ".", 2)[0])
104104
}
105105

0 commit comments

Comments
 (0)