Fix function indentation for new override syntax

[jclsn]

The new override syntax is not completely fixed for functions yet. The indentation works with

do_compile() {
    make
}

but

do_compile:append() {
make
}

will not get indented right.

[kergoth]

Hmm, well spotted. This is a tough one given the way the indenter is currently implemented. Right now, we punt to the existing Vim shell indenter if we didn't pick up on the python function definition, but as a result, it means that initial indent is purely handled by the shell indenter, which doesn't support colons in definitions. I think we can easily fix this for python functions by correcting the pattern for bbPyFuncDef, I'll see about doing that. Fixing it for shell will involve shifting the handling the initial indent from shell.vim to us, if that's possible.

I'll look into fixing the python one in the next day or two, the other may have to wait until I get more time, or pull in Chris Laplante if he's still around.

[jclsn]

Sounds good! I suspected that it is not so easy. I was looking at the indent.vim, but did not understand a thing. It is not urgent I guess, so take your time.

…

Am 06.06.2022 um 20:46 schrieb Christopher Larson ***@***.***>:  Hmm, well spotted. This is a tough one given the way the indenter is currently implemented. Right now, we punt to the existing Vim shell indenter if we didn't pick up on the python function definition, but as a result, it means that initial indent is purely handled by the shell indenter, which doesn't support colons in definitions. I think we can easily fix this for python functions by correcting the pattern for bbPyFuncDef, I'll see about doing that. Fixing it for shell will involve shifting the handling the initial indent from shell.vim to us, if that's possible. I'll look into fixing the python one in the next day or two, the other may have to wait until I get more time, or pull in Chris Laplante if he's still around. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.