Skip to content

Silent fails of the 'presubmit' build workflow #2950

@theunrepentantgeek

Description

@theunrepentantgeek

Description

Observed Behavior:

The presubmit build workflow (defined in presubmit.yaml ) is failing without triggering a failed build status.

For example, look at this set of workflow runs where it appears that 5/7 runs worked:

Image

However, all five of the "green" workflow runs are themselves failures, all having failed with this error:

# github.com/google/go-licenses
Error: ../../../go/pkg/mod/github.com/google/go-licenses@v1.6.0/save.go:125:9: cannot use func(src string) (bool, error) {…} (value of type func(src string) (bool, error)) as func(srcinfo os.FileInfo, src string, dest string) (bool, error) value in struct literal

Expected Behavior:

Compilation failures during CI workflows should result in Failed workflows.

Reproduction Steps (Please include YAML):

Go to the list of presubmit workflow runs and inspect any recent run, even those showing "Passed".

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/bugCategorizes issue or PR as related to a bug.needs-prioritytriage/acceptedIndicates an issue or PR is ready to be actively worked on.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions