address review

Author: alicelyy

aws/aws.go

@@ -947,24 +947,24 @@ func isErrorModificationNotFound(err error) bool {
 	return strings.HasPrefix(err.Error(), awsErrorModificationNotFound)
 }
 
-func (s *awsOps) IsVolumesReadyToExpand(volumeIDs []*string) (bool, error) {
+func (s *awsOps) AreVolumesReadyToExpand(volumeIDs []*string) (bool, error) {
 	modificationStateRequest := &ec2.DescribeVolumesModificationsInput{
 		VolumeIds: volumeIDs,
 	}
 	describeOutput, err := s.ec2.DescribeVolumesModifications(modificationStateRequest)
-	states := describeOutput.VolumesModifications
 	if err != nil {
 		// modification state not found, this indicates no change has occurred before.
 		if isErrorModificationNotFound(err) {
 			return true, nil
 		}
-		return false, fmt.Errorf("unable to get volumes' modification states: %v", err)
+		return false, fmt.Errorf("unable to get modification states for aws volumes: %v", err)
 	}
+	states := describeOutput.VolumesModifications
 
 	var state string
 	for i := 0; i < len(states); i++ {
 		if states[i] == nil || states[i].ModificationState == nil {
-			logrus.Infof("volume modification state is nil for volume id: %s", *volumeIDs[i])
+			logrus.Debugf("volume modification state is nil for volume id: %s", *volumeIDs[i])
 			continue
 		}
 

azure/azure.go

@@ -580,7 +580,7 @@ func (a *azureOps) DeleteFrom(diskName, _ string) error {
 	return a.Delete(diskName, nil)
 }
 
-func (a *azureOps) IsVolumesReadyToExpand(volumeIDs []*string) (bool, error) {
+func (a *azureOps) AreVolumesReadyToExpand(volumeIDs []*string) (bool, error) {
 	return true, &cloudops.ErrNotSupported{
 		Operation: "azureOps.IsVolumesReadyToExpand",
 	}

backoff/exponential.go

@@ -436,8 +436,8 @@ func (e *exponentialBackoff) DevicePath(volumeID string) (string, error) {
 	return devicePath, origErr
 }
 
-func (e *exponentialBackoff) IsVolumesReadyToExpand(volumeIDs []*string) (bool, error) {
-	return e.cloudOps.IsVolumesReadyToExpand(volumeIDs)
+func (e *exponentialBackoff) AreVolumesReadyToExpand(volumeIDs []*string) (bool, error) {
+	return e.cloudOps.AreVolumesReadyToExpand(volumeIDs)
 }
 
 func (e *exponentialBackoff) Expand(volumeID string, targetSize uint64, options map[string]string) (uint64, error) {

cloudops.go

@@ -131,7 +131,7 @@ type Storage interface {
 	Attach(volumeID string, options map[string]string) (string, error)
 	// IsVolumeReadyToExpand pre-checks if a pool of volumes are in a state that can
 	// be modified. Should be called before sending an expand request to the cloud provider.
-	IsVolumesReadyToExpand(volumeIDs []*string) (bool, error)
+	AreVolumesReadyToExpand(volumeIDs []*string) (bool, error)
 	// Expand expands the provided device from the existing size to the new size
 	// It returns the new size of the device. It is a blocking API where it will
 	// only return once the requested size is validated with the cloud provider or

gce/gce.go

@@ -664,7 +664,7 @@ func (s *gceOps) GetDeviceID(disk interface{}) (string, error) {
 	}
 }
 
-func (s *gceOps) IsVolumesReadyToExpand(volumeIDs []*string) (bool, error) {
+func (s *gceOps) AreVolumesReadyToExpand(volumeIDs []*string) (bool, error) {
 	return true, &cloudops.ErrNotSupported{
 		Operation: "gceOps:IsVolumesReadyToExpand",
 	}