PWX-24572 : Set and Get InstanceGroupSize implementation (#108)

* PWX-24572 : Set and Get InstanceGroupSize implementation

* PWX-24572: fix golint issues

* PWX-24572 : addressing review comments

* PWX-24572 : addressing review comments

* go fmt file

Author: nikita-bhatia

oracle/oracle.go

@@ -3,6 +3,7 @@ package oracle
 import (
 	"context"
 	"encoding/json"
+	"errors"
 	"fmt"
 	"io/ioutil"
 	"net/http"
@@ -38,13 +39,16 @@ const (
 	MetadataUserDataKey   = "user_data"
 	metadataTenancyIDKey  = "oke-tenancy-id"
 	metadataPoolIDKey     = "oke-pool-id"
+	metadataClusterIDKey  = "oke-cluster-id"
 	envPrefix             = "PX_ORACLE"
 	envInstanceID         = "INSTANCE_ID"
 	envRegion             = "INSTANCE_REGION"
 	envAvailabilityDomain = "INSTNACE_AVAILABILITY_DOMAIN"
 	envCompartmentID      = "COMPARTMENT_ID"
 	envTenancyID          = "TENANCY_ID"
 	envPoolID             = "POOL_ID"
+	envClusterID          = "CLUSTER_ID"
+	defaultTimeout        = 5 * time.Minute
 )
 
 type oracleOps struct {
@@ -56,6 +60,7 @@ type oracleOps struct {
 	compartmentID           string
 	tenancyID               string
 	poolID                  string
+	clusterID               string
 	volumeAttachmentMapping map[string]*string
 	storage                 core.BlockstorageClient
 	compute                 core.ComputeClient
@@ -125,6 +130,11 @@ func getInfoFromEnv(oracleOps *oracleOps) error {
 	if err != nil {
 		return err
 	}
+
+	oracleOps.clusterID, err = cloudops.GetEnvValueStrict(envClusterID)
+	if err != nil {
+		return err
+	}
 	return nil
 }
 
@@ -204,7 +214,7 @@ func GetMetadata() (map[string]interface{}, error) {
 }
 
 func getInfoFromMetadata(oracleOps *oracleOps) error {
-	var tenancyID, poolID string
+	var tenancyID, poolID, clusterID string
 	var ok bool
 	metadata, err := GetMetadata()
 	if err != nil {
@@ -219,13 +229,17 @@ func getInfoFromMetadata(oracleOps *oracleOps) error {
 				if poolID, ok = okeMetadata[metadataPoolIDKey].(string); !ok {
 					return fmt.Errorf("can not get pool ID from oracle metadata service. error: [%v]", err)
 				}
+				if clusterID, ok = okeMetadata[metadataClusterIDKey].(string); !ok {
+					return fmt.Errorf("can not get cluster ID from oracle metadata service. error: [%v]", err)
+				}
 			}
 		} else {
 			return fmt.Errorf("can not get OKE metadata from oracle metadata service. error: [%v]", err)
 		}
 	}
 	oracleOps.tenancyID = tenancyID
 	oracleOps.poolID = poolID
+	oracleOps.clusterID = clusterID
 	if oracleOps.instance, ok = metadata[metadataInstanceIDkey].(string); !ok {
 		return fmt.Errorf("can not get instance id from oracle metadata service. error: [%v]", err)
 	}
@@ -459,6 +473,111 @@ func (o *oracleOps) Delete(volumeID string) error {
 	return nil
 }
 
+func (o *oracleOps) SetInstanceGroupSize(instanceGroupID string, count int64, timeout time.Duration) error {
+
+	if timeout == 0*time.Second {
+		timeout = defaultTimeout
+	}
+
+	instanceGroupSize := int(count)
+
+	//get nodepool by ID to be updated
+	nodePoolReq := containerengine.ListNodePoolsRequest{CompartmentId: &o.compartmentID, Name: &instanceGroupID, ClusterId: &o.clusterID}
+	nodePools, err := o.containerEngine.ListNodePools(context.Background(), nodePoolReq)
+	if err != nil {
+		return err
+	}
+
+	if len(nodePools.Items) == 0 {
+		return errors.New("No node pool found with name " + instanceGroupID)
+	}
+	numberOfDomains := len(nodePools.Items[0].NodeConfigDetails.PlacementConfigs)
+	totalClusterSize := numberOfDomains * instanceGroupSize
+	logrus.Println("Setting instanceGroupSize to ", totalClusterSize, " in total ", numberOfDomains, " regions.")
+
+	//get all availabliity domain
+	nodePoolPlacementConfigDetails := make([]containerengine.NodePoolPlacementConfigDetails, numberOfDomains)
+
+	for i, placementConfigs := range nodePools.Items[0].NodeConfigDetails.PlacementConfigs {
+		nodePoolPlacementConfigDetails[i].AvailabilityDomain = placementConfigs.AvailabilityDomain
+		nodePoolPlacementConfigDetails[i].SubnetId = placementConfigs.SubnetId
+	}
+
+	//update node pools
+	req := containerengine.UpdateNodePoolRequest{
+		NodePoolId: nodePools.Items[0].Id, //get node pool id
+		UpdateNodePoolDetails: containerengine.UpdateNodePoolDetails{
+			NodeConfigDetails: &containerengine.UpdateNodePoolNodeConfigDetails{
+				Size:             &totalClusterSize,
+				PlacementConfigs: nodePoolPlacementConfigDetails,
+			},
+		},
+	}
+
+	resp, err := o.containerEngine.UpdateNodePool(context.Background(), req)
+	if err != nil {
+		return err
+	}
+
+	err = o.waitTillWorkStatusIsSucceeded(resp.OpcRequestId, resp.OpcWorkRequestId, timeout)
+	if err != nil {
+		return err
+	}
+
+	return nil
+}
+
+func (o *oracleOps) waitTillWorkStatusIsSucceeded(opcRequestID, opcWorkRequestID *string, timeout time.Duration) error {
+	workReq := containerengine.GetWorkRequestRequest{OpcRequestId: opcRequestID,
+		WorkRequestId: opcWorkRequestID}
+
+	f := func() (interface{}, bool, error) {
+		workResp, err := o.containerEngine.GetWorkRequest(context.Background(), workReq)
+		if err != nil {
+			return nil, true, err
+		}
+
+		if workResp.Status == containerengine.WorkRequestStatusSucceeded {
+			return workResp.Status, false, nil
+		}
+
+		logrus.Debugf("Work status is in [%s] state", workResp.Status)
+		return nil, true, fmt.Errorf("Work status is in [%s] state", workResp.Status)
+	}
+	_, err := task.DoRetryWithTimeout(f, timeout, 10*time.Second)
+	return err
+}
+
+func (o *oracleOps) GetInstanceGroupSize(instanceGroupID string) (int64, error) {
+
+	var count int64
+
+	nodePoolReq := containerengine.ListNodePoolsRequest{CompartmentId: &o.compartmentID, Name: &instanceGroupID, ClusterId: &o.clusterID}
+	nodePools, err := o.containerEngine.ListNodePools(context.Background(), nodePoolReq)
+	if err != nil {
+		return 0, err
+	}
+
+	if len(nodePools.Items) == 0 {
+		return 0, errors.New("No node pool found with name " + instanceGroupID)
+	}
+
+	req := containerengine.GetNodePoolRequest{NodePoolId: nodePools.Items[0].Id}
+
+	resp, err := o.containerEngine.GetNodePool(context.Background(), req)
+
+	if err != nil {
+		return 0, err
+	}
+
+	for _, node := range resp.Nodes {
+		if node.LifecycleState == containerengine.NodeLifecycleStateActive {
+			count++
+		}
+	}
+	return count, nil
+}
+
 // Attach volumeID, accepts attachOptions as opaque data
 // Return attach path.
 func (o *oracleOps) Attach(volumeID string, options map[string]string) (string, error) {
@@ -608,4 +727,5 @@ func (o *oracleOps) GetDeviceID(vol interface{}) (string, error) {
 		return *d.Id, nil
 	}
 	return "", fmt.Errorf("invalid type: %v given to GetDeviceID", vol)
+
 }

oracle/oracle_test.go

@@ -29,8 +29,9 @@ func TestAll(t *testing.T) {
 		t.Skipf("skipping Oracle tests as environment is not set...\n")
 	}
 
-	compartmentID, _ := cloudops.GetEnvValueStrict(fmt.Sprintf("%s_%s", envPrefix, envCompartmentID))
-	availabilityDomain, _ := cloudops.GetEnvValueStrict(fmt.Sprintf("%s_%s", envPrefix, envAvailabilityDomain))
+
+	compartmentID, _ := cloudops.GetEnvValueStrict(fmt.Sprintf("%s", envCompartmentID))
+	availabilityDomain, _ := cloudops.GetEnvValueStrict(fmt.Sprintf("%s", envAvailabilityDomain))
 	oracleVol := &core.Volume{
 		SizeInGBs:          common.Int64(newDiskSizeInGB),
 		CompartmentId:      common.String(compartmentID),