PWX-29976: Datastore recommendation in vSphere 8 (#138)

vSphere 8.0 is making it mandatory to specify NumCPUs and MemoryMB.
    This was stopping px from coming up on such cluster. This patch
    fixes it.

Signed-off-by: Naveen Revanna <nrevanna@purestorage.com>

Author: nrevanna

vsphere/vsphere.go

@@ -30,6 +30,7 @@ import (
 
 const (
 	vSphereDataStoreLock = "vsphere-ds-lock"
+	configProperty       = "config.hardware"
 )
 
 type vsphereOps struct {
@@ -818,6 +819,16 @@ func recommendDatastore(
 	}
 
 	resourcePoolRef := resourcePool.Reference()
+	var o mo.VirtualMachine
+	err = vmObj.Properties(ctx, vmObj.Reference(), []string{configProperty}, &o)
+	if err != nil || o.Config == nil {
+		// In case of an error defaulting to 4 CPUs and 8GB
+		spec.NumCPUs = 4
+		spec.MemoryMB = 8 * 1024
+	} else {
+		spec.NumCPUs = o.Config.Hardware.NumCPU
+		spec.MemoryMB = int64(o.Config.Hardware.MemoryMB)
+	}
 
 	sps := types.StoragePlacementSpec{
 		Type:             string(types.StoragePlacementSpecPlacementTypeCreate),