Merge pull request #847 from linode/dev

Release v5.65.1

Author: ezilber-akamai

.github/pull_request_template.md

@@ -7,7 +7,3 @@
 **What are the steps to reproduce the issue or verify the changes?**
 
 **How do I run the relevant unit/integration tests?**
-
-## 📷 Preview
-
-**If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.**

.github/workflows/e2e-suite.yml

@@ -40,6 +40,14 @@ on:
         options:
           - 'true'
           - 'false'
+      test_report_upload:
+        description: 'Indicates whether to upload the test report to object storage. Defaults to "false"'
+        required: false
+        default: 'false'
+        type: choice
+        options:
+          - 'true'
+          - 'false'
 
   push:
     branches:
@@ -127,7 +135,7 @@ jobs:
 
       - name: Upload Test Report as Artifact
         if: always()
-        uses: actions/upload-artifact@v5
+        uses: actions/upload-artifact@v6
         with:
           name: test-report-file
           if-no-files-found: ignore
@@ -231,7 +239,8 @@ jobs:
   process-upload-report:
     runs-on: ubuntu-latest
     needs: [integration_tests]
-    if: always() && github.repository == 'linode/linode-cli' # Run even if integration tests fail and only on main repository
+    # Run even if integration tests fail on main repository AND (push event OR (manually triggered and test_report_upload is true))
+    if: always() && github.repository == 'linode/linode-cli' && (github.event_name == 'push' || (github.event_name == 'workflow_dispatch' && inputs.test_report_upload == 'true'))
     outputs:
       summary: ${{ steps.set-test-summary.outputs.summary }}
 
@@ -243,7 +252,7 @@ jobs:
           submodules: 'recursive'
 
       - name: Download test report
-        uses: actions/download-artifact@v6
+        uses: actions/download-artifact@v7
         with:
           name: test-report-file
 
@@ -258,7 +267,6 @@ jobs:
       - name: Set release version env
         run: echo "RELEASE_VERSION=${GITHUB_REF#refs/*/}" >> $GITHUB_ENV
 
-
       - name: Add variables and upload test results
         if: always()
         run: |

.github/workflows/release.yml

@@ -39,10 +39,10 @@ jobs:
         run: make requirements
 
       - name: Set up QEMU
-        uses: docker/setup-qemu-action@29109295f81e9208d7d86ff1c6c12d2833863392 # pin@v3.6.0
+        uses: docker/setup-qemu-action@c7c53464625b32c7a7e944ae62b3e17d2b600130 # pin@v3.7.0
 
       - name: Set up Docker Buildx
-        uses: docker/setup-buildx-action@e468171a9de216ec08956ac3ada2f0791b6bd435 # pin@v3.11.1
+        uses: docker/setup-buildx-action@8d2750c68a42422c14e847fe6c8ac0403b4cbd6f # pin@v3.12.0
 
       - name: Login to Docker Hub
         uses: docker/login-action@5e57cd118135c172c3672efd75eb46360885c0ef # pin@v3.6.0

.github/workflows/remote-release-trigger.yml

@@ -66,7 +66,7 @@ jobs:
           commit_sha: ${{ steps.calculate_head_sha.outputs.commit_sha }}
 
       - name: Release
-        uses: softprops/action-gh-release@6da8fa9354ddfdc4aeace5fc48d7f679b5214090 # pin@v2.4.1
+        uses: softprops/action-gh-release@a06a81a03ee405af7f2048a818ed3f03bbf83c7b # pin@v2.5.0
         with:
           target_commitish: 'main'
           token: ${{ steps.generate_token.outputs.token }}

README.md

@@ -21,7 +21,7 @@ Visit the [Wiki](../../wiki/Installation) for more information.
 
 ## Contributing
 
-This CLI is generated from the [OpenAPI specification for Linode's API](https://github.com/linode/linode-api-docs).  As
+This CLI is generated from the [OpenAPI specification for Linode's API](https://github.com/linode/linode-api-openapi).  As
 such, many changes are made directly to the spec.
 
 Please follow the [Contributing Guidelines](https://github.com/linode/linode-cli/blob/main/CONTRIBUTING.md) when making a contribution.

linodecli/arg_helpers.py

@@ -4,6 +4,7 @@
 This module defines argument parsing, plugin registration, and plugin removal
 functionalities for the Linode CLI.
 """
+
 import sys
 from argparse import ArgumentParser
 from configparser import ConfigParser

linodecli/cli.py

@@ -286,7 +286,7 @@ def user_agent(self) -> str:
         """
         return (
             f"linode-cli/{self.version} "
-            f"linode-api-docs/{self.spec_version} "
+            f"linode-api-openapi/{self.spec_version} "
             f"python/{version_info[0]}.{version_info[1]}.{version_info[2]}"
         )
 

linodecli/completion.py

@@ -2,6 +2,7 @@
 """
 Contains any code relevant to generating/updating shell completions for linode-cli
 """
+
 from string import Template
 
 from openapi3 import OpenAPI
@@ -93,12 +94,10 @@ def get_bash_completions(ops):
 complete -F _linode_cli lin"""
     )
 
-    command_template = Template(
-        """$command)
+    command_template = Template("""$command)
         COMPREPLY=( $(compgen -W "$actions --help" -- ${cur}) )
         return 0
-        ;;"""
-    )
+        ;;""")
 
     command_blocks = [
         command_template.safe_substitute(

linodecli/configuration/auth.py

@@ -214,13 +214,11 @@ def _get_token_terminal(base_url: str) -> Tuple[str, str]:
     :returns: A tuple containing the user's username and token.
     :rtype: Tuple[str, str]
     """
-    print(
-        f"""
+    print(f"""
 First, we need a Personal Access Token.  To get one, please visit
 {TOKEN_GENERATION_URL} and click
 "Create a Personal Access Token".  The CLI needs access to everything
-on your account to work correctly."""
-    )
+on your account to work correctly.""")
 
     while True:
         token = input("Personal Access Token: ")
@@ -329,15 +327,13 @@ def log_message(self, form, *args):  # pylint: disable=arguments-differ
     # figure out the URL to direct the user to and print out the prompt
     # pylint: disable-next=line-too-long
     url = f"https://login.linode.com/oauth/authorize?client_id={OAUTH_CLIENT_ID}&response_type=token&scopes=*&redirect_uri=http://localhost:{serv.server_address[1]}"
-    print(
-        f"""A browser should open directing you to this URL to authenticate:
+    print(f"""A browser should open directing you to this URL to authenticate:
 
 {url}
 
 If you are not automatically directed there, please copy/paste the link into your browser
 to continue..
-"""
-    )
+""")
 
     webbrowser.open(url)
 
@@ -348,7 +344,7 @@ def log_message(self, form, *args):  # pylint: disable=arguments-differ
     except KeyboardInterrupt:
         print(
             "\nGiving up.  If you couldn't get web authentication to work, please "
-            "try token using a token by invoking with `linode-cli configure --token`, "
+            "try using a token by invoking with `linode-cli configure --token`, "
             "and open an issue at https://github.com/linode/linode-cli",
             file=sys.stderr,
         )

linodecli/configuration/helpers.py

@@ -97,11 +97,9 @@ def _check_browsers() -> bool:
 
     # pylint: disable-next=protected-access
     if not KNOWN_GOOD_BROWSERS.intersection(webbrowser._tryorder):
-        print(
-            """
+        print("""
 This tool defaults to web-based authentication,
-however no known-working browsers were found."""
-        )
+however no known-working browsers were found.""")
         while True:
             r = input("Try it anyway? [y/N]: ")
             if r.lower() in "yn ":