Submit code review suggestions

Author: psnoch-akamai

test/integration/conftest.py

@@ -730,6 +730,16 @@ def test_monitor_client(get_monitor_token_for_db_entities):
     return client, entity_ids
 
 
+def get_alert_channels_list(test_linode_client):
+    channels = list(test_linode_client.monitor.alert_channels())
+    if len(channels) == 0:
+        pytest.fail(
+            "No alert channels available for testing. Please create an alert channel and try again."
+        )
+
+    return channels
+
+
 @pytest.fixture(scope="session")
 def create_alert_service_definition(test_linode_client):
     rule_criteria = {
@@ -758,17 +768,12 @@ def create_alert_service_definition(test_linode_client):
         "polling_interval_seconds": 900,
         "trigger_occurrences": 3,
     }
-    channels = list(test_linode_client.monitor.alert_channels())
-    if len(channels) == 0:
-        raise Exception(
-            "No alert channels available for testing. Please create an alert channel and try again."
-        )
     alert = test_linode_client.monitor.create_alert_definition(
         service_type="dbaas",
         label=get_test_label() + "-service-definition",
         severity=1,
         description="description",
-        channel_ids=[channels[0].id],
+        channel_ids=[get_alert_channels_list(test_linode_client)[0].id],
         rule_criteria=rule_criteria,
         trigger_conditions=trigger_conditions,
     )

test/integration/models/linode/test_linode.py

@@ -237,8 +237,7 @@ def wait_for_clone_complete_and_delete_linode(
     end_time = time.time() + timeout
     while time.time() < end_time:
         try:
-            linode.delete()
-            return True
+            return linode.delete()
         except ApiError as err:
             if "[400] Linode is the target of an ongoing clone" not in str(err):
                 raise UnexpectedResponseError(f"Unexpected delete linode error")
@@ -255,11 +254,11 @@ def instance_type_condition(linode: Instance, type: str):
 def test_get_linodes_verify_alerts(test_linode_client, create_linode):
     linodes_list = test_linode_client.linode.instances().lists[0]
     assert len(linodes_list) > 0
-    assert linodes_list[0].alerts.cpu >= 0
-    assert linodes_list[0].alerts.io >= 0
-    assert linodes_list[0].alerts.network_in >= 0
-    assert linodes_list[0].alerts.network_out >= 0
-    assert linodes_list[0].alerts.transfer_quota >= 0
+    assert linodes_list[0].alerts.cpu
+    assert linodes_list[0].alerts.io
+    assert linodes_list[0].alerts.network_in
+    assert linodes_list[0].alerts.network_out
+    assert linodes_list[0].alerts.transfer_quota
 
 
 def test_get_linode(test_linode_client, linode_with_volume_firewall):
@@ -310,8 +309,8 @@ def test_linode_rebuild(test_linode_client):
 
     assert linode.status == "rebuilding"
     assert linode.image.id == "linode/debian12"
-    assert linode.alerts.cpu >= 0
-    assert linode.alerts.io >= 0
+    assert linode.alerts.cpu
+    assert linode.alerts.io
 
     assert linode.disk_encryption == InstanceDiskEncryptionType.disabled