Skip to content

Commit b4db18a

Browse files
fix: [UIE-8447] - autofill fix and clear errors on blur (#12032)
* autofill fix, error fix * Added changeset: autofill fix and clear API errors on blur for config item input * save button label fix
1 parent 712c2c3 commit b4db18a

4 files changed

Lines changed: 14 additions & 5 deletions

File tree

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@linode/manager": Fixed
3+
---
4+
5+
incorrect restart-related label on Save button, autofill not applying values, and API errors not clearing on config field blur ([#12032](https://github.com/linode/manager/pull/12032))

packages/manager/src/features/Databases/DatabaseDetail/DatabaseAdvancedConfiguration/DatabaseAdvancedConfigurationDrawer.tsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,6 @@ export const DatabaseAdvancedConfigurationDrawer = (props: Props) => {
140140

141141
const handleRemoveConfig = (index: number) => {
142142
remove(index);
143-
reset(watch(), { keepDirty: true });
144143
};
145144

146145
const handleClose = () => {
@@ -238,7 +237,10 @@ export const DatabaseAdvancedConfigurationDrawer = (props: Props) => {
238237
fieldState.error?.message ||
239238
getConfigAPIError(config, updateDatabaseError)
240239
}
241-
onBlur={field.onBlur}
240+
onBlur={() => {
241+
setUpdateDatabaseError(null);
242+
field.onBlur();
243+
}}
242244
onChange={field.onChange}
243245
onRemove={() => handleRemoveConfig(index)}
244246
/>

packages/manager/src/features/Databases/DatabaseDetail/DatabaseAdvancedConfiguration/DatabaseConfigurationItem.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ export const DatabaseConfigurationItem = (props: Props) => {
5757
);
5858
return (
5959
<Autocomplete
60+
autoHighlight
6061
disableClearable
6162
isOptionEqualToValue={(option, value) => option.label === value.label}
6263
label={''}

packages/manager/src/features/Databases/DatabaseDetail/DatabaseAdvancedConfiguration/utilities.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -242,9 +242,10 @@ export const hasRestartCluster = (
242242
dirtyFields: any,
243243
configs: ConfigurationOption[]
244244
): string => {
245-
return Object.keys(dirtyFields.configs || {}).some(
246-
(key) => configs[Number(key)]?.requires_restart
247-
)
245+
return configs.some((config, index) => {
246+
const isDirtyValue = dirtyFields.configs?.[index]?.value;
247+
return isDirtyValue && config.requires_restart;
248+
})
248249
? 'Save and Restart Service'
249250
: 'Save';
250251
};

0 commit comments

Comments
 (0)