Skip to content

Commit adda3e4

Browse files
committed
fix(builder): remove false dependencies from codec libraries
- Remove glslang, libvpl, nvcodecheaders from libvpx, x264, x265, dav1d, rav1e, vvenc - Remove libwebp from libvpx dependencies - Add clarifying comment to Library.Dependencies field These codec libraries have no actual build-time dependency on hardware acceleration headers. Hardware acceleration is integrated at FFmpeg level, not within individual codec libraries.
1 parent 267cf3e commit adda3e4

2 files changed

Lines changed: 7 additions & 13 deletions

File tree

internal/builder/libraries.go

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -526,8 +526,7 @@ var libvpx = &Library{
526526
"--enable-static",
527527
}
528528
},
529-
LinkLibs: []string{"libvpx"},
530-
Dependencies: []*Library{glslang, libvpl, nvcodecheaders, libwebp},
529+
LinkLibs: []string{"libvpx"},
531530
}
532531

533532
// x264 - H.264/AVC video encoder
@@ -558,8 +557,7 @@ var x264 = &Library{
558557
}
559558
return nil
560559
},
561-
LinkLibs: []string{"libx264"},
562-
Dependencies: []*Library{glslang, libvpl, nvcodecheaders},
560+
LinkLibs: []string{"libx264"},
563561
}
564562

565563
// x265 - H.265/HEVC video encoder 7.9M
@@ -579,8 +577,7 @@ var x265 = &Library{
579577
"-DLOGGED_PRIMITIVES=OFF", // Reduce logging overhead
580578
}
581579
},
582-
LinkLibs: []string{"libx265"},
583-
Dependencies: []*Library{glslang, libvpl, nvcodecheaders},
580+
LinkLibs: []string{"libx265"},
584581
}
585582

586583
// dav1d - AV1 video decoder
@@ -597,8 +594,7 @@ var dav1d = &Library{
597594
"-Denable_tests=false",
598595
}
599596
},
600-
LinkLibs: []string{"libdav1d"},
601-
Dependencies: []*Library{glslang, libvpl, nvcodecheaders},
597+
LinkLibs: []string{"libdav1d"},
602598
}
603599

604600
// rav1e - AV1 video encoder
@@ -621,8 +617,7 @@ var rav1e = &Library{
621617
"--release")
622618
},
623619
},
624-
LinkLibs: []string{"librav1e"},
625-
Dependencies: []*Library{glslang, libvpl, nvcodecheaders},
620+
LinkLibs: []string{"librav1e"},
626621
}
627622

628623
// vvenc - H.266/VVC video encoder
@@ -641,8 +636,7 @@ var vvenc = &Library{
641636
"-DVVENC_ENABLE_BUILD_TYPE_POSTFIX=OFF", // No -s/-ds library postfix
642637
}
643638
},
644-
LinkLibs: []string{"libvvenc"},
645-
Dependencies: []*Library{glslang, libvpl, nvcodecheaders},
639+
LinkLibs: []string{"libvvenc"},
646640
}
647641

648642
// openssl - TLS/SSL library for HTTPS, RTMPS, SRT, RIST protocols

internal/builder/library.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ type Library struct {
2323
PostExtract func(srcPath string) error // optional patches
2424
SkipAutoFlags bool // Skip automatic CFLAGS/LDFLAGS (for non-standard configure scripts like zlib)
2525
LinkLibs []string // Libraries to link in final static lib (nil for header-only)
26-
Dependencies []*Library
26+
Dependencies []*Library // Build-time dependencies; platform-specific deps are auto-filtered via ShouldBuild()
2727
}
2828

2929
// BuildSystem defines the interface for different build systems

0 commit comments

Comments
 (0)