SNI tray icon's context menu: Items' labels not aligned if some of them use icons and others don't

[Photon89]

Distribution

Fedora Rawhide

Package version

6.7.4

Graphics hardware in use

No response

Frequency

Always

Bug description

It's a rather cosmetic issue, no biggie.

I am trying to implement a tray icon for Shutter using SNI. It works well, the tray icon is shown as expected, left click and right click actions are interpreted correctly.

One issue exists though: In the context menu some items use icons, the cosmetic issue is that these icons don't reserve horizontal space globally, and thus the text labels are not aligned.

Here is a screenshot:

As you can see the first item's label is not aligned with the other items' labels, because it is the only one without an icon.

Steps to reproduce

You could test the PR which implements the tray icon: shutter-project/shutter#837

Expected behavior

All labels should be aligned, so items without an icon should be shifted to the right as if there was an icon.

Additional information

No response

[mtwebster]

Hmm I'm not really sure... pure SNI/AppIndicator take a roundabout path to Cinnamon's panel.

We have a separate standalone daemon (xapp-sn-watcher) that advertises StatusNotifierWatcher and then builds XAppStatusIcons based on that.

We rely on dbusmenu-gtk3 to generate real GtkMenus there:
https://github.com/linuxmint/xapp/blob/master/xapp-sn-watcher/sn-item.c#L594

Which then get told to pop up later by the XApp applet in Cinnamon.

I wonder if that's just how dbusmenu-gtk3 constructs menus - I know Gtk3 folks deprecated GtkImageMenuItem years ago and wanted everyone to build their own - which sucked because you could end up with alignment problems with mixed content.

Maybe use a dummy/blank image?

[Photon89]

Gtk3 folks are really difficult sometimes... thanks for the hint, I'll look into it on our side!