Skip to content

Commit e3fb579

Browse files
dceraolorodrigovivi
authored andcommitted
drm/xe/pxp: Don't allow PXP on older PTL GSC FWs
On PTL, older GSC FWs have a bug that can cause them to crash during PXP invalidation events, which leads to a complete loss of power management on the media GT. Therefore, we can't use PXP on FWs that have this bug, which was fixed in PTL GSC build 1396. Fixes: b1dcec9 ("drm/xe/ptl: Enable PXP for PTL") Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com> Cc: Julia Filipchuk <julia.filipchuk@intel.com> Reviewed-by: Julia Filipchuk <julia.filipchuk@intel.com> Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com> Link: https://patch.msgid.link/20260324153718.3155504-10-daniele.ceraolospurio@intel.com (cherry picked from commit 6eb04caaa972934c9b6cea0e0c29e466bf9a346f) Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
1 parent 76903b2 commit e3fb579

1 file changed

Lines changed: 12 additions & 0 deletions

File tree

drivers/gpu/drm/xe/xe_pxp.c

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -380,6 +380,18 @@ int xe_pxp_init(struct xe_device *xe)
380380
return 0;
381381
}
382382

383+
/*
384+
* On PTL, older GSC FWs have a bug that can cause them to crash during
385+
* PXP invalidation events, which leads to a complete loss of power
386+
* management on the media GT. Therefore, we can't use PXP on FWs that
387+
* have this bug, which was fixed in PTL GSC build 1396.
388+
*/
389+
if (xe->info.platform == XE_PANTHERLAKE &&
390+
gt->uc.gsc.fw.versions.found[XE_UC_FW_VER_RELEASE].build < 1396) {
391+
drm_info(&xe->drm, "PXP requires PTL GSC build 1396 or newer\n");
392+
return 0;
393+
}
394+
383395
pxp = drmm_kzalloc(&xe->drm, sizeof(struct xe_pxp), GFP_KERNEL);
384396
if (!pxp) {
385397
err = -ENOMEM;

0 commit comments

Comments
 (0)