Merge pull request #1866 from livecode/ide-cleanup

[[ Cleanup ]] Clean up a couple of bits of IDE code

Author: Monte Goulding

Toolset/palettes/menubar/revmenubar.livecodescript

@@ -2367,27 +2367,6 @@ end markMenuItem
 
 ################################################################################
 
-command revMenuBarUpdateRecentPaths
-  revIDECleanRecentPaths
-  
-  local tRecentPathsMenu
-  put revIDEGetRecentPathsAsMenu() into tRecentPathsMenu
-  
-  local tFileButtonText
-  put the text of button "File" of group "revMenuBar" of me into tFileButtonText
-   
-  local tStart
-  set the wholeMatches to true
-  put lineOffset("Open Recent File", tFileButtonText) + 1 into tStart
-  set the wholeMatches to false
-   
-  local tEnd
-  put lineOffset("&Close/W", tFileButtonText) - 1 into tEnd
-  put tRecentPathsMenu into line tStart to tEnd of tFileButtonText
-  set the text of button "File" of group "revMenuBar" of me to tFileButtonText
-  
-end revMenuBarUpdateRecentPaths
-
 # OK-2007-05-03: Bug 4833.
 # Parameters
 #   pObject : reference to the object to list handlers for

Toolset/palettes/tools/revtools.livecodescript

@@ -138,16 +138,17 @@ on framePreferenceSelected pPreference, pValue
          revIDESetPreference "revTools_columns", pValue
          break
       case "revTools_show"
-         local tCurrentPreferenceValue, tPreferencePosition
+         local tCurrentPreferenceValue, tPreferencePosition, tItemOffset
          put revIDEGetPreference("revTools_show") into tCurrentPreferenceValue
-         if pValue is among the items of tCurrentPreferenceValue then
-            repeat with x = the number of items of tCurrentPreferenceValue down to 1
-               if item x of tCurrentPreferenceValue is pValue then
-                  delete item x of tCurrentPreferenceValue
-               end if
-            end repeat
+         put itemOffset(pValue, tCurrentPreferenceValue) into tItemOffset
+         if tItemOffset is not 0 then
+            delete item tItemOffset of tCurrentPreferenceValue
          else
-            put "," & pValue after tCurrentPreferenceValue
+            if tCurrentPreferenceValue is empty then
+               put pValue into tCurrentPreferenceValue
+            else
+               put comma & pValue after tCurrentPreferenceValue
+            end if
          end if
          revIDESetPreference "revTools_show", tCurrentPreferenceValue
          break