Merge pull request #1668 from livecode/bugfix-20041

[[ Bug 20041 ]] Update tags & wait array when a stack name changes

Author: livecodepanos

Toolset/palettes/tutorial/revtutorial.livecodescript

@@ -1720,9 +1720,19 @@ on revInitialiseTutorial
    revIDESetPreference "cToolbarIcons", true
    revIDESetPreference "idePropertyInspector_labels", false
 
+   -- Ensure we know when stack names change
+   revIDESubscribe "ideNameChanged"
+   
    unlock screen
 end revInitialiseTutorial
 
+on ideNameChanged pOldName, pNewName, pTarget
+   if word 1 of pTarget is "stack" then
+      -- Update all our long IDs if we're tracking this stack
+      revTutorialStackNameChanged pOldName, pNewName
+   end if
+end ideNameChanged
+
 on revTutorialInitialiseStep
    put false into sWaiting
    put false into sIsInterlude
@@ -3401,6 +3411,30 @@ function revTutorialReparentChild pObject
    return the long id of pObject
 end revTutorialReparentChild
 
+command revTutorialStackNameChanged pOldName, pNewName
+   -- Update the tagged objects
+   repeat for each key tType in sTaggedObjects
+      repeat for each key tTag in sTaggedObjects[tType]
+         replace "stack" && quote & pOldName & quote \ 
+               with  "stack" && quote & pNewName & quote \
+               in sTaggedObjects[tType][tTag]
+      end repeat
+   end repeat
+   
+   -- Update any wait state if we are waiting. Now that the tagged objects 
+   -- are updated just call DoWait again with the current wait state.The 
+   -- type/tag in the sWait array will resolve to the updated long ID
+   if sWait is not empty then
+      -- if new condition is immediately satisified (i.e. if we are waiting for a
+      -- stack name change) then sWaiting will still be false after revTutorialDoWait
+      put false into sWaiting
+      revTutorialDoWait sWait
+      if not sWaiting then
+         revTutorialWaitConditionSatisfied
+      end if
+   end if
+end revTutorialStackNameChanged
+
 # Take a tutorial tagged object (an array with 'type' and 'tag' keys)
 # and return the corresponding long ID (or list of long IDs for 'set' types)
 function revTutorialResolveObjectToLongID pTaggedObject, pUpdate

notes/bugfix-18915.md

@@ -0,0 +1 @@
+# Allow a 'set the name of stack' step in interactive tutorials

notes/bugfix-20041.md

@@ -0,0 +1 @@
+# Prevent tutorials breaking when stack name is changed