Merge pull request #1832 from montegoulding/remotedebuggerissues

[[ Bug 19359, 19357 ]] Remote debugger issues

Author: livecodepanos

Toolset/libraries/revdebuggerlibrary.livecodescript

@@ -20,7 +20,7 @@ on extensionFinalize
    remove the script of me from front
 end extensionFinalize
 
-
+local sLastBreakInfo
 
 ################################################################################
 #
@@ -534,6 +534,7 @@ end __SetValueDo
 # Description
 #   Runs the currently debugging script until the next breakpoint
 command revDebuggerRun
+   delete variable sLastBreakInfo
    set the traceStack to empty
    set the traceUntil to 65535
    set the traceReturn to true
@@ -543,6 +544,7 @@ end revDebuggerRun
 # Description
 #  Performs the debugger "stop" function, terminates the script currently being debugged
 command revDebuggerStop
+   delete variable sLastBreakInfo
    # When executing certain structures, the debugger will continue to loop until the
    # breakpoints property becomes empty. In order to make sure the debugger always
    # exits when asked to, we set the breakpoints to empty here and restore them again
@@ -2208,6 +2210,8 @@ local sLastAllowedContext
 #   was called from, then updates the script editor. If the last debug action
 #   was "Step Into", always updates the script editor.
 on trace pHandler, pLine, pPosition
+   delete variable sLastBreakInfo
+   
    local tTarget
    put __ResolveTarget(the long id of the target, line -2 of the executionContexts) into tTarget
 
@@ -2282,6 +2286,8 @@ end trace
 #   all open script editors to switch to edit mode, then does the debugger run
 #   action.
 on traceDone
+   delete variable sLastBreakInfo
+   
    # OK-2009-03-13 : Once we've got a traceDone, shut down the debugger first,
    # as otherwise we have to trace through all the script editor code which slows things down.
    revDebuggerRun
@@ -2306,6 +2312,19 @@ on traceError pHandler, pLine, pPosition, pError
       pass traceError
    end if
 
+   -- shield from same message with error being repeatedly called
+   local tBreakInfo
+   put the long id of the target into tBreakInfo["target"]
+   put pHandler into tBreakInfo["handler"]
+   put pLine into tBreakInfo["line"]
+   put pPosition into tBreakInfo["position"]
+   put pError into tBreakInfo["error"]
+   if tBreakInfo is sLastBreakInfo then
+      pass traceError
+   else
+      put tBreakInfo into sLastBreakInfo
+   end if
+   
    if item 1 of pError is kErrorRecursionLimit then
       local tMessage
       put "The handler: " & pHandler & " has reached the recursion limit of: " & the recursionLimit & "." & return & \
@@ -2382,6 +2401,17 @@ on traceBreak pHandler, pLine
       pass traceBreak
    end if
 
+   -- shield from same message with breakpoint being repeatedly called
+   local tBreakInfo
+   put the long id of the target into tBreakInfo["target"]
+   put pHandler into tBreakInfo["handler"]
+   put pLine into tBreakInfo["line"]
+   if tBreakInfo is sLastBreakInfo then
+      pass traceBreak
+   else
+      put tBreakInfo into sLastBreakInfo
+   end if
+   
    local tTarget
    put __ResolveTarget(the long id of the target, line -2 of the executionContexts) into tTarget
 

Toolset/palettes/script editor/behaviors/revsescripttabsbehavior.livecodescript

@@ -317,7 +317,7 @@ command addTab pObject
    put tControl into sTabButtonMap[the number of lines of the keys of sTabMap]
    set the cRawLabel of tControl to tFriendlyName
    set the visible of tControl to true
-   set the cTooltip of tControl to the long name of tObject
+   set the cTooltip of tControl to revDebuggerObjectLongName(tObject)
 
    local tNewWidth
    put min(kMaxTabWidth, the cFormattedWidth of tControl + 5) into tNewWidth

notes/bugfix-19359.md

@@ -0,0 +1 @@
+# Ensure the debugger and remote debugger ignore breakpoints and errors if they are repeatedly triggered when execution has not been continued