[[ ExtensionStandaloneSettings ]] Make settings editable on inclusions list

This patch adds a settings icon to the inclusions pane of the standalone
settings when there are per-extension standalone settings available.

Clicking on this pops up a modeless 'inspector' for any properties
declared in standaloneSettings metadata in the extension.

Author: livecodeali

Toolset/palettes/inspector/behaviors/revinspectoreditorbehavior.livecodescript

@@ -205,15 +205,18 @@ after editorPopup pClickLoc
       exit editorPopup
    end if
    create invisible stack tStackName
-   dispatch "setAsBehavior" to stack revIDEPaletteResourcePath("behaviors/revinspectorpopupstackbehavior.livecodescript", the long id of stack "revInspector") with the long id of stack tStackName
+   dispatch "setAsBehavior" to stack \
+         revIDEPaletteResourcePath("behaviors/revinspectorpopupstackbehavior.livecodescript", \
+         the long id of stack "revInspector") with the long id of stack tStackName
    set the frameHidden of stack tStackName to true
    dispatch "inspectorGenerateGroups" to stack tStackName with sPropertyInfo["popup"]
    dispatch "inspectorLayoutGroups" to stack tStackName with sPropertyInfo["popup"]
    dispatch "inspectorFillGroups" to stack tStackName with sPopupData
    set the editorTarget of stack tStackName to the long id of me
    // In LC 9.0 DP-7 you can resize the inspector window, by putting all the contents in a group "inspector" and adding a vScrollbar to the group
    // but 'modeless stack X' breaks the vScrollbar of groups, so ensure the popup stack has the correct height before going 'modeless'
-   set the height of stack tStackName to the formattedHeight of group "inspector"
+   set the height of stack tStackName to \
+         the formattedHeight of group "inspector" of stack tStackName
    set the title of stack tStackName to the rowLabel of the owner of me
    modeless stack tStackName
 end editorPopup

Toolset/palettes/standalone settings/revstandalonesettingsbehavior.livecodescript

@@ -175,9 +175,13 @@ command updateCardSize
 end updateCardSize
 
 on resumeStack
-  if the short name of this stack is "revStandaloneSettings" then
-    send "preOpenCard" to the current card 
-  end if
+   if the short name of this stack is "revStandaloneSettings" then
+      local tMainstack
+      put the mainStack of the topStack into tMainstack
+      if tMainstack is getTargetStack() then
+         send "preOpenCard" to this card of me in 0 millisecs
+      end if
+   end if
 end resumeStack
 
 # Parameters

Toolset/palettes/standalone settings/revstandalonesettingsinclusionsrowbehavior.livecodescript

@@ -11,13 +11,15 @@ on FillInData pDataA, pRow
    else if pDataA["label"] is not empty then put pDataA["label"] into tLabel
    if tLabel is empty then put "Extension Title" into tLabel
 
+   set the cLabel of me to tLabel
+   
    if pDataA["author"] is not empty then put pDataA["author"] into tAuthor
    if tAuthor is empty then put "Unknown Author" into tAuthor
 
    put tLabel into field "description" of me
 
    local tIconName, tIconPath
-   revSBInclusionIconFromType pDataA["type"], pDataA["id"], tIconName, tIconPath
+   revIDEExtensionIconFromType pDataA["type"], pDataA["id"], tIconName, tIconPath
 
    if tIconPath is not empty then
       set the iconPath of widget "icon" of me to tIconPath
@@ -33,6 +35,13 @@ on FillInData pDataA, pRow
       end if
    end repeat
 
+   if revIDEExtensionStandaloneSettingsInfo(pDataA["id"]) \
+         is not empty then
+      show widget "Settings" of me
+   else
+      hide widget "Settings" of me
+   end if
+   
    set the cRow of me to pRow
 end FillInData
 
@@ -75,12 +84,47 @@ on LayoutControl pControlRect
       put the left of image tItem of me into tRight
    end repeat
 
+   subtract 2*tPadding from tRight
+   set the right of widget "Settings" of me to tRight
 end LayoutControl
 
 on mouseUp
-   dispatch "rowClicked" to card "inclusions" of this stack with the cRow of me
+   if the long id of the target is \
+         the long id of widget "Settings" of me then
+      popupExtensionStandaloneSettings the cTypeId of me, the mouseLoc
+   else
+      dispatch "rowClicked" to card "inclusions" of this stack with the cRow of me
+   end if
 end mouseUp
 
+command popupExtensionStandaloneSettings pId, pClickLoc
+   -- TODO: Fetch existing value!
+   set the behavior of the long id of widget "Settings" of me \
+         to the long id of stack revIDEPaletteResourcePath("behaviors/revinspectoreditorbehavior.livecodescript", the long ID of stack "revInspector")
+   set the rowLabel of me to the cLabel of me && "Standalone Settings"
+   local tPropertyInfo, tPropData, tStack
+   dispatch function "getTargetStack" to me
+   put the result into tStack
+   put "Extension Standalone Settings" into tPropertyInfo["property_name"]
+   put revIDEStandaloneSettingsInfoOfExtension(pId) \
+         into tPropertyInfo["popup"]
+   set the editorPropertyInfo of widget "Settings" of me to tPropertyInfo
+   set the editorPopupData of widget "Settings" of me to \
+         revIDEStandaloneSettingsOfExtension(tStack, pId)
+   send "editorPopup pClickLoc" to widget "Settings" of me
+end popupExtensionStandaloneSettings
+
+on valueChanged pProp, pValue
+   -- extension standalone settings don't get set directly
+   -- they live in cRevStandaloneSettings[<ext id>][key]
+   -- and get merged at build time
+   local tSettings
+   dispatch function "getSettings" to me
+   put the result into tSettings
+   put pValue into tSettings[the cTypeId of me][pProp]
+   dispatch "setSettings" to me with tSettings
+end valueChanged
+
 on mouseDown
 
 end mouseDown