fix: remove duplicate provider probes in tests

Author: KSemenenko

DotPilot.Core/Providers/Services/AgentProviderStatusSnapshotReader.cs

@@ -105,14 +105,14 @@ private static async ValueTask<ProviderStatusProbeResult> BuildProviderStatusAsy
             }
             else
             {
-                installedVersion = AgentSessionCommandProbe.ReadVersion(executablePath, ["--version"]);
-                actions.Add(new ProviderActionDescriptor("Open CLI", "CLI detected on PATH.", $"{profile.CommandName} --version"));
-
                 var metadata = await ResolveMetadataAsync(profile, executablePath, cancellationToken).ConfigureAwait(false);
-                installedVersion = ResolveInstalledVersion(
-                    installedVersion,
-                    metadata.InstalledVersion,
-                    profile.CommandName);
+                installedVersion = metadata.InstalledVersion;
+                if (!LooksLikeInstalledVersion(installedVersion, profile.CommandName))
+                {
+                    installedVersion = AgentSessionCommandProbe.ReadVersion(executablePath, ["--version"]);
+                }
+
+                actions.Add(new ProviderActionDescriptor("Open CLI", "CLI detected on PATH.", $"{profile.CommandName} --version"));
                 suggestedModelName = ResolveSuggestedModel(profile.DefaultModelName, metadata.SuggestedModelName);
                 supportedModelNames = ResolveSupportedModels(
                     profile.DefaultModelName,
@@ -195,21 +195,6 @@ private static string ResolveSuggestedModel(string defaultModelName, string? sug
             : suggestedModelName;
     }
 
-    private static string? ResolveInstalledVersion(
-        string? probedInstalledVersion,
-        string? discoveredInstalledVersion,
-        string commandName)
-    {
-        if (LooksLikeInstalledVersion(discoveredInstalledVersion, commandName))
-        {
-            return discoveredInstalledVersion;
-        }
-
-        return string.IsNullOrWhiteSpace(probedInstalledVersion)
-            ? discoveredInstalledVersion
-            : probedInstalledVersion;
-    }
-
     private static bool LooksLikeInstalledVersion(string? installedVersion, string commandName)
     {
         if (string.IsNullOrWhiteSpace(installedVersion))

DotPilot.Tests/ChatSessions/Execution/AgentSessionServiceTests.cs

@@ -639,7 +639,32 @@ private async ValueTask DisposeAsyncCore()
             await _provider.DisposeAsync();
             if (!string.IsNullOrWhiteSpace(_tempRootPath) && Directory.Exists(_tempRootPath))
             {
-                Directory.Delete(_tempRootPath, recursive: true);
+                await DeleteDirectoryWithRetryAsync(_tempRootPath);
+            }
+        }
+    }
+
+    private static async Task DeleteDirectoryWithRetryAsync(string path)
+    {
+        for (var attempt = 0; attempt < 5; attempt++)
+        {
+            if (!Directory.Exists(path))
+            {
+                return;
+            }
+
+            try
+            {
+                Directory.Delete(path, recursive: true);
+                return;
+            }
+            catch (IOException) when (attempt < 4)
+            {
+                await Task.Delay(100);
+            }
+            catch (UnauthorizedAccessException) when (attempt < 4)
+            {
+                await Task.Delay(100);
             }
         }
     }

DotPilot.Tests/Workspace/Services/StartupWorkspaceHydrationTests.cs

@@ -60,7 +60,7 @@ public async Task EnsureHydratedAsyncKeepsHydrationRetryableAfterATransientWorks
             hydration.IsHydrating.Should().BeFalse();
             hydration.IsReady.Should().BeFalse();
 
-            Directory.Delete(databasePath);
+            await DeleteDirectoryWithRetryAsync(databasePath);
 
             await hydration.EnsureHydratedAsync(CancellationToken.None);
 
@@ -71,7 +71,7 @@ public async Task EnsureHydratedAsyncKeepsHydrationRetryableAfterATransientWorks
         {
             if (Directory.Exists(rootPath))
             {
-                Directory.Delete(rootPath, recursive: true);
+                await DeleteDirectoryWithRetryAsync(rootPath);
             }
         }
     }
@@ -104,4 +104,29 @@ public ValueTask DisposeAsync()
             return Provider.DisposeAsync();
         }
     }
+
+    private static async Task DeleteDirectoryWithRetryAsync(string path)
+    {
+        for (var attempt = 0; attempt < 5; attempt++)
+        {
+            if (!Directory.Exists(path))
+            {
+                return;
+            }
+
+            try
+            {
+                Directory.Delete(path, recursive: true);
+                return;
+            }
+            catch (IOException) when (attempt < 4)
+            {
+                await Task.Delay(100);
+            }
+            catch (UnauthorizedAccessException) when (attempt < 4)
+            {
+                await Task.Delay(100);
+            }
+        }
+    }
 }