Address all 11 PR review comments

1. Remove unused imports (patch, PropertyMock) from test_select_star_expansion
2. Fix JOIN depth '6+' -> 'no depth limit' in query.py docstring
3. Fix stale 'auto-inject TOP' comment in _odata.py
4. Fix Learn-incompatible docstring types in tables.py list_columns
5. Fix Learn-incompatible docstring types in tables.py list_relationships
6. Fix list_table_relationships docstring: add ManyToOne
7. Fix cross-join regex to catch unaliased FROM account, contact
8. Fix write regex to catch comment-prefixed writes (/* */ and --)
9. Narrow odata_expands exception handling (KeyError/AttributeError/ValueError)
10. Consistent JOIN depth claims across all docs

770 unit tests passing.

Author: Saurabh Badenkal

src/PowerPlatform/Dataverse/data/_odata.py

@@ -837,12 +837,12 @@ def _do_request(url: str, *, params: Optional[Dict[str, Any]] = None) -> Dict[st
 
     # ----------------------- SQL guardrail patterns --------------------
     _SQL_WRITE_RE = re.compile(
-        r"^\s*(?:INSERT|UPDATE|DELETE|DROP|TRUNCATE|ALTER|CREATE|EXEC|GRANT|REVOKE|BULK)\b",
-        re.IGNORECASE,
+        r"^\s*(?:/\*.*?\*/\s*|--[^\n]*\n\s*)*(?:INSERT|UPDATE|DELETE|DROP|TRUNCATE|ALTER|CREATE|EXEC|GRANT|REVOKE|BULK)\b",
+        re.IGNORECASE | re.DOTALL,
     )
     _SQL_LEADING_WILDCARD_RE = re.compile(r"\bLIKE\s+'%[^']", re.IGNORECASE)
     _SQL_IMPLICIT_CROSS_JOIN_RE = re.compile(
-        r"\bFROM\s+[A-Za-z0-9_]+\s+[A-Za-z0-9_]+\s*,\s*[A-Za-z0-9_]+",
+        r"\bFROM\s+[A-Za-z0-9_]+(?:\s+[A-Za-z0-9_]+)?\s*,\s*[A-Za-z0-9_]+",
         re.IGNORECASE,
     )
     _SQL_HAS_JOIN_RE = re.compile(r"\bJOIN\b", re.IGNORECASE)
@@ -1048,7 +1048,7 @@ def _query_sql(self, sql: str) -> list[dict[str, Any]]:
         # Auto-expand SELECT * into explicit column names
         sql = self._expand_select_star(sql, logical)
 
-        # Apply safety guardrails (block writes, auto-inject TOP, warn on risky patterns)
+        # Apply safety guardrails (block unsupported syntax, warn on risky patterns)
         sql = self._sql_guardrails(sql)
 
         entity_set = self._entity_set_from_schema_name(logical)

src/PowerPlatform/Dataverse/operations/query.py

@@ -99,7 +99,7 @@ def sql(self, sql: str) -> List[Record]:
 
             SELECT / SELECT DISTINCT / SELECT TOP N (0-5000)
             FROM table [alias]
-            INNER JOIN / LEFT JOIN (multi-table, up to 6+ tables)
+            INNER JOIN / LEFT JOIN (multi-table, no depth limit)
             WHERE (=, !=, >, <, >=, <=, LIKE, IN, NOT IN, IS NULL,
                    IS NOT NULL, BETWEEN, AND, OR, nested parentheses)
             GROUP BY column
@@ -481,8 +481,8 @@ def odata_expands(
             try:
                 with self._client._scoped_odata() as od:
                     target_set = od._entity_set_from_schema_name(target)
-            except Exception:
-                pass
+            except (KeyError, AttributeError, ValueError):
+                pass  # Entity set resolution failed; target_set stays empty
 
             result.append(
                 {

src/PowerPlatform/Dataverse/operations/tables.py

@@ -723,13 +723,13 @@ def list_columns(
         :type table: :class:`str`
         :param select: Optional list of property names to project via
             ``$select``.  Values are passed as-is (PascalCase).
-        :type select: :class:`list` of :class:`str` or None
+        :type select: list[str] or None
         :param filter: Optional OData ``$filter`` expression.  For example,
             ``"AttributeType eq 'String'"`` returns only string columns.
         :type filter: :class:`str` or None
 
         :return: List of raw attribute metadata dictionaries.
-        :rtype: :class:`list` of :class:`dict`
+        :rtype: list[dict[str, typing.Any]]
 
         :raises ~PowerPlatform.Dataverse.core.errors.MetadataError:
             If the table is not found.
@@ -774,10 +774,10 @@ def list_relationships(
         :type filter: :class:`str` or None
         :param select: Optional list of property names to project via
             ``$select``.  Values are passed as-is (PascalCase).
-        :type select: :class:`list` of :class:`str` or None
+        :type select: list[str] or None
 
         :return: List of raw relationship metadata dictionaries.
-        :rtype: :class:`list` of :class:`dict`
+        :rtype: list[dict[str, typing.Any]]
 
         :raises ~PowerPlatform.Dataverse.core.errors.HttpError:
             If the Web API request fails.
@@ -827,9 +827,9 @@ def list_table_relationships(
             ``$select``.  Values are passed as-is (PascalCase).
         :type select: :class:`list` of :class:`str` or None
 
-        :return: Combined list of one-to-many and many-to-many relationship
-            metadata dictionaries.
-        :rtype: :class:`list` of :class:`dict`
+        :return: Combined list of one-to-many, many-to-one, and many-to-many
+            relationship metadata dictionaries.
+        :rtype: list[dict[str, typing.Any]]
 
         :raises ~PowerPlatform.Dataverse.core.errors.MetadataError:
             If the table is not found.

tests/unit/data/test_select_star_expansion.py

@@ -4,7 +4,7 @@
 """Unit tests for SELECT * auto-expansion in _query_sql."""
 
 import pytest
-from unittest.mock import MagicMock, patch, PropertyMock
+from unittest.mock import MagicMock
 
 from PowerPlatform.Dataverse.data._odata import _ODataClient