fix: address 5 Copilot review comments (round 2)

- sql_joins(): fix docstring example to not use aliases with join_clause
  (join_clause uses full table name; use sql_join() for aliased queries)
- sql_examples: replace _value JOIN pattern with sql_join() helper
- list_table_relationships: docstring now mentions ManyToOne
- remove unused VALIDATION_SQL_CROSS_JOIN_BLOCKED import
- PR description: cartesian updated from ValidationError to UserWarning

Author: Saurabh Badenkal

examples/advanced/sql_examples.py

@@ -408,22 +408,21 @@ def _run_examples(client):
         # 13. INNER JOIN
         # ==============================================================
         heading(13, "SQL -- INNER JOIN")
-        print("Use the lookup column's logical name (e.g. _new_teamid_value).")
-
-        child_cols = backoff(lambda: client.tables.list_columns(child_table, select=["LogicalName", "AttributeType"]))
-        lookup_col = "_new_teamid_value"
-        for c in child_cols:
-            ln = c.get("LogicalName", "")
-            if "teamid" in ln.lower() and ln.startswith("_"):
-                lookup_col = ln
-                break
+        print("Use the lookup attribute's logical name (e.g. new_teamid) for JOINs.")
+
+        # Use sql_join() to auto-discover the relationship and build
+        # the JOIN clause with proper aliases.
+        lookup_col = "new_teamid"  # Lookup logical name, NOT _..._value
+        join_clause = client.query.sql_join(
+            from_table=child_table,
+            to_table=parent_table,
+            from_alias="tk",
+            to_alias="t",
+        )
         print(f"[INFO] Lookup column: {lookup_col}")
+        print(f"[INFO] Generated JOIN: {join_clause}")
 
-        sql = (
-            f"SELECT t.new_code, tk.new_title, tk.new_hours "
-            f"FROM {child_table} tk "
-            f"INNER JOIN {parent_table} t ON tk.{lookup_col} = t.{parent_id_col}"
-        )
+        sql = f"SELECT t.new_code, tk.new_title, tk.new_hours " f"FROM {child_table} tk " f"{join_clause}"
         log_call('client.query.sql("...INNER JOIN...")')
         try:
             results = backoff(lambda: client.query.sql(sql))
@@ -443,7 +442,7 @@ def _run_examples(client):
             f"SELECT t.new_code, tk.new_title "
             f"FROM {parent_table} t "
             f"LEFT JOIN {child_table} tk ON t.{parent_id_col} = tk.{lookup_col}"
-        )
+        )  # lookup_col = logical name, NOT _..._value
         log_call('client.query.sql("...LEFT JOIN...")')
         try:
             results = backoff(lambda: client.query.sql(sql))
@@ -459,7 +458,7 @@ def _run_examples(client):
             f"SELECT t.new_code, COUNT(tk.new_sqldemotaskid) as task_count, "
             f"SUM(tk.new_hours) as total_hours "
             f"FROM {parent_table} t "
-            f"JOIN {child_table} tk ON t.{parent_id_col} = tk.{lookup_col} "
+            f"JOIN {child_table} tk ON t.{parent_id_col} = tk.{lookup_col} "  # logical name
             f"GROUP BY t.new_code"
         )
         log_call('client.query.sql("...JOIN...GROUP BY...")')

src/PowerPlatform/Dataverse/data/_odata.py

@@ -31,7 +31,6 @@
     VALIDATION_SQL_NOT_STRING,
     VALIDATION_SQL_EMPTY,
     VALIDATION_SQL_WRITE_BLOCKED,
-    VALIDATION_SQL_CROSS_JOIN_BLOCKED,
     VALIDATION_SQL_UNSUPPORTED_SYNTAX,
     METADATA_ENTITYSET_NOT_FOUND,
     METADATA_ENTITYSET_NAME_MISSING,

src/PowerPlatform/Dataverse/operations/query.py

@@ -292,16 +292,23 @@ def sql_joins(
 
         :rtype: list[dict[str, typing.Any]]
 
+        .. note::
+
+            The ``join_clause`` value references the source table by its
+            **full name** (e.g. ``ON contact.col = ...``), so the FROM
+            clause must also use the unaliased table name.  For queries
+            that need aliases, use :meth:`sql_join` instead.
+
         Example::
 
             joins = client.query.sql_joins("contact")
             for j in joins:
                 print(f"{j['column']:30s} -> {j['target']}.{j['target_pk']}")
                 print(f"  {j['join_clause']}")
 
-            # Use in a query
+            # Use in a query (no alias on the FROM table)
             j = next(j for j in joins if j['target'] == 'account')
-            sql = f"SELECT TOP 10 c.fullname, a.name FROM contact c {j['join_clause']}"
+            sql = f"SELECT TOP 10 contact.fullname, a.name FROM contact {j['join_clause']}"
         """
         table_lower = table.lower()
         rels = self._client.tables.list_table_relationships(table)

src/PowerPlatform/Dataverse/operations/tables.py

@@ -813,9 +813,10 @@ def list_table_relationships(
     ) -> List[Dict[str, Any]]:
         """List all relationships for a specific table.
 
-        Combines one-to-many and many-to-many relationships for the given
-        table by querying both
-        ``EntityDefinitions({id})/OneToManyRelationships`` and
+        Combines one-to-many, many-to-one, and many-to-many relationships
+        for the given table by querying
+        ``EntityDefinitions({id})/OneToManyRelationships``,
+        ``EntityDefinitions({id})/ManyToOneRelationships``, and
         ``EntityDefinitions({id})/ManyToManyRelationships``.
 
         :param table: Schema name of the table (e.g. ``"account"``).