Merge pull request github#21437 from igfoo/igfoo/onemk

igfoo · web-flow · commit 341059d2d001 · 2026-03-10T15:36:38.000Z
C++: Small simplification
diff --git a/cpp/ql/lib/semmle/code/cpp/controlflow/IRGuards.qll b/cpp/ql/lib/semmle/code/cpp/controlflow/IRGuards.qll
@@ -1663,7 +1663,7 @@ private module Cached {
   private predicate compares_ge(
     ValueNumber test, Operand left, Operand right, int k, boolean isGe, GuardValue value
   ) {
-    exists(int onemk | k = 1 - onemk | compares_lt(test, right, left, onemk, isGe, value))
+    compares_lt(test, right, left, 1 - k, isGe, value)
   }
 
   /** Rearrange various simple comparisons into `left < right + k` form. */

Original file line number	Diff line number	Diff line change
`@@ -1663,7 +1663,7 @@ private module Cached {`
`1663`	`1663`	`private predicate compares_ge(`
`1664`	`1664`	`ValueNumber test, Operand left, Operand right, int k, boolean isGe, GuardValue value`
`1665`	`1665`	`) {`
`1666`		`- exists(int onemk \| k = 1 - onemk \| compares_lt(test, right, left, onemk, isGe, value))`
	`1666`	`+ compares_lt(test, right, left, 1 - k, isGe, value)`
`1667`	`1667`	`}`
`1668`	`1668`
`1669`	`1669`	/** Rearrange various simple comparisons into `left < right + k` form. */