Merge branch 'main' into saumya/pool-c++

Author: gargsaumya

mssql_python/__init__.py

@@ -53,3 +53,18 @@
 apilevel = "2.0"
 paramstyle = "qmark"
 threadsafety = 1
+
+from .pooling import PoolingManager
+def pooling(max_size=100, idle_timeout=600):
+#     """
+#     Enable connection pooling with the specified parameters.
+    
+#     Args:
+#         max_size (int): Maximum number of connections in the pool.
+#         idle_timeout (int): Time in seconds before idle connections are closed.
+    
+#     Returns:
+#         None
+#     """
+    PoolingManager.enable(max_size, idle_timeout) 
+      

mssql_python/connection.py

@@ -11,7 +11,7 @@
 from mssql_python.constants import ConstantsDDBC as ddbc_sql_const
 from mssql_python.helpers import add_driver_to_connection_str, check_error
 from mssql_python import ddbc_bindings
-# from mssql_python.pooling import PoolingManager
+from mssql_python.pooling import PoolingManager
 
 logger = get_logger()
 
@@ -58,8 +58,7 @@ def __init__(self, connection_str: str = "", autocommit: bool = False, attrs_bef
             connection_str, **kwargs
         )
         self._attrs_before = attrs_before or {}
-        # self._pooling = PoolingManager.is_enabled()
-        self._pooling = False
+        self._pooling = PoolingManager.is_enabled()
         self._conn = ddbc_bindings.Connection(self.connection_str, self._pooling, self._attrs_before)
         self.setautocommit(autocommit)
 

mssql_python/pooling.py

@@ -0,0 +1,29 @@
+# mssql_python/pooling.py
+from mssql_python import ddbc_bindings
+import threading
+
+class PoolingManager:
+    _enabled = False
+    _lock = threading.Lock()
+    _config = {
+        "max_size": 100,
+        "idle_timeout": 600
+    }
+
+    @classmethod
+    def enable(cls, max_size=100, idle_timeout=600):
+        with cls._lock:
+            if cls._enabled:
+                return
+
+            if max_size <= 0 or idle_timeout < 0:
+                raise ValueError("Invalid pooling parameters")
+
+            ddbc_bindings.enable_pooling(max_size, idle_timeout)
+            cls._config["max_size"] = max_size
+            cls._config["idle_timeout"] = idle_timeout
+            cls._enabled = True
+
+    @classmethod
+    def is_enabled(cls):
+        return cls._enabled

mssql_python/pybind/connection/connection.h

@@ -14,6 +14,7 @@
 class Connection {
 public:
     Connection(const std::wstring& connStr, bool fromPool);
+
     ~Connection();
 
     // Establish the connection using the stored connection string.

mssql_python/pybind/ddbc_bindings.cpp

@@ -1927,6 +1927,7 @@ PYBIND11_MODULE(ddbc_bindings, m) {
 
     py::class_<SqlHandle, SqlHandlePtr>(m, "SqlHandle")
         .def("free", &SqlHandle::free, "Free the handle");
+  
     py::class_<ConnectionHandle>(m, "Connection")
         .def(py::init<const std::wstring&, bool, const py::dict&>(), py::arg("conn_str"), py::arg("use_pool"), py::arg("attrs_before") = py::dict())
         .def("close", &ConnectionHandle::close, "Close the connection")