Merged PR 5248: Fix numeric data type check in DDBCSQLExecute

Theekshna Kotian · Theekshna Kotian · commit 2fcbcc679b6f · 2025-01-30T19:38:46.000Z
Fix numeric data type check in DDBCSQLExecute

Related work items: #33298
diff --git a/mssql_python/pybind/ddbc_bindings.cpp b/mssql_python/pybind/ddbc_bindings.cpp
@@ -594,7 +594,7 @@ SQLRETURN SQLExecute_wrap(const intptr_t statementHandle, const std::wstring& qu
                 }
                 case SQL_C_NUMERIC:
                {
-                    if (!py::isinstance<py::class_<NumericData>>(param)) {
+                    if (!py::isinstance<NumericData>(param)) {
                         ThrowStdException(MakeParamMismatchErrorStr("SQL_C_NUMERIC", paramIndex));
                     }
                     NumericData decimalParam = param.cast<NumericData>();

Original file line number	Diff line number	Diff line change
`@@ -594,7 +594,7 @@ SQLRETURN SQLExecute_wrap(const intptr_t statementHandle, const std::wstring& qu`
`594`	`594`	`}`
`595`	`595`	`case SQL_C_NUMERIC:`
`596`	`596`	`{`
`597`		`- if (!py::isinstance<py::class_<NumericData>>(param)) {`
	`597`	`+ if (!py::isinstance<NumericData>(param)) {`
`598`	`598`	`ThrowStdException(MakeParamMismatchErrorStr("SQL_C_NUMERIC", paramIndex));`
`599`	`599`	`}`
`600`	`600`	`NumericData decimalParam = param.cast<NumericData>();`