Skip to content

Commit a9ee888

Browse files
committed
Merge branch 'saumya/conn_implementation' into saumya/integratec++class
2 parents 3240394 + c8dfd0e commit a9ee888

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

mssql_python/pybind/connection/connection.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ void Connection::allocateDbcHandle() {
4949
_dbcHandle = std::make_shared<SqlHandle>(SQL_HANDLE_DBC, dbc);
5050
}
5151

52-
SQLRETURN Connection::connect(const py::dict& attrs_before) {
52+
void Connection::connect(const py::dict& attrs_before) {
5353
LOG("Connecting to database");
5454
// Apply access token before connect
5555
if (!attrs_before.is_none() && py::len(attrs_before) > 0) {

mssql_python/pybind/connection/connection.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ class Connection {
1717
~Connection();
1818

1919
// Establish the connection using the stored connection string.
20-
SQLRETURN connect(const py::dict& attrs_before = py::dict());
20+
void connect(const py::dict& attrs_before = py::dict());
2121

2222
// Disconnect and free the connection handle.
2323
void disconnect();

0 commit comments

Comments
 (0)