Merge remote-tracking branch 'origin/main' into saumya/stress-tests-gh

Author: gargsaumya

.github/workflows/issue-acknowledge.yml

@@ -11,11 +11,11 @@ jobs:
   acknowledge:
     runs-on: ubuntu-latest
     permissions:
-      issues: read
+      issues: write
     steps:
       # Step 1: Wait 15 minutes
       - name: Wait 15 minutes
-        run: sleep 10
+        run: sleep 900
 
       # Step 2: Check if a maintainer already responded
       - name: Check for existing maintainer response
@@ -24,7 +24,7 @@ jobs:
         with:
           github-token: ${{ secrets.GITHUB_TOKEN }}
           script: |
-            const maintainers = ['sumitmsft','dlevy-msft-sql']; 
+            const maintainers = ['sumitmsft','dlevy-msft-sql','gargsaumya','bewithgaurav','subrata-ms','jahnvi480','saurabh500']; 
 
             const comments = await github.rest.issues.listComments({
               owner: context.repo.owner,
@@ -44,11 +44,25 @@ jobs:
         if: steps.check.outputs.skip == 'false'
         uses: actions/github-script@v7
         with:
-          github-token: ${{ secrets.SUMIT_PAT_FOR_AUTO_RESPONSE }}
+          github-token: ${{ secrets.GITHUB_TOKEN }}
           script: |
             await github.rest.issues.createComment({
               owner: context.repo.owner,
               repo: context.repo.repo,
               issue_number: context.payload.issue.number,
-              body: `Hi @${context.payload.issue.user.login}, thank you for opening this issue!\n\nOur team will review it shortly. We aim to triage all new issues within 24-48 hours and get back to you.\n\nThank you for your patience!`
+              body: `Hi @${context.payload.issue.user.login}, thank you for opening this issue!\n\nOur team will review it shortly. We aim to triage all new issues within 24-48 hours and get back to you.\n\nIf you have additional information to share, please feel free to update the issue.\n\nThank you for your patience!`
+            });
+
+      # Step 4: Add "triage needed" label if no maintainer has responded
+      - name: Add triage needed label
+        if: steps.check.outputs.skip == 'false'
+        uses: actions/github-script@v7
+        with:
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          script: |
+            await github.rest.issues.addLabels({
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+              issue_number: context.payload.issue.number,
+              labels: ['triage needed']
             });

.github/workflows/pr-code-coverage.yml

@@ -426,8 +426,8 @@ jobs:
             --arg covered_lines "${{ env.COVERED_LINES }}" \
             --arg total_lines "${{ env.TOTAL_LINES }}" \
             --arg patch_coverage_pct "${{ env.PATCH_COVERAGE_PCT }}" \
-            --arg low_coverage_files "${{ env.LOW_COVERAGE_FILES }}" \
-            --arg patch_coverage_summary "${{ env.PATCH_COVERAGE_SUMMARY }}" \
+            --arg low_coverage_files "$LOW_COVERAGE_FILES" \
+            --arg patch_coverage_summary "$PATCH_COVERAGE_SUMMARY" \
             --arg ado_url "${{ env.ADO_URL }}" \
             '{
               pr_number: $pr_number,

.gitignore

@@ -61,5 +61,8 @@ build/
 *venv*/
 **/*venv*/
 
+# Extracted mssql_py_core (from eng/scripts/install-mssql-py-core)
+mssql_py_core/
+
 # learning files
 learnings/

OneBranchPipelines/dummy-release-pipeline.yml

@@ -174,6 +174,14 @@ extends:
                     Write-Host "Symbols: $(if ($symbols) { $symbols.Count } else { 0 }) files"
                     Write-Host "====================================="
               
+              # Step 3.5: Validate mssql-py-core is a stable version (no dev/alpha/beta/rc)
+              - task: PowerShell@2
+                displayName: '[TEST] Validate mssql-py-core is a stable version'
+                inputs:
+                  targetType: 'filePath'
+                  filePath: '$(Build.SourcesDirectory)\OneBranchPipelines\scripts\validate-release-versions.ps1'
+                  arguments: '-VersionFile "$(Build.SourcesDirectory)\artifacts\dist\mssql-py-core.version"'
+
               # Step 4: Verify wheel integrity
               - task: PowerShell@2
                 displayName: '[TEST] Verify Wheel Integrity'

OneBranchPipelines/jobs/consolidate-artifacts-job.yml

@@ -26,7 +26,8 @@ jobs:
         value: '$(Build.ArtifactStagingDirectory)'
 
     steps:
-      - checkout: none  # No source code needed for consolidation
+      - checkout: self
+        fetchDepth: 1
 
       # Download ALL artifacts from current build
       # Matrix jobs publish as: Windows_<JobId>, macOS_<JobId>, Linux_<JobId>
@@ -112,6 +113,13 @@ jobs:
         displayName: 'Consolidate Windows symbols (optional)'
         continueOnError: true
       
+      # Include mssql-py-core version file for traceability
+      - bash: |
+          set -e
+          cp $(Build.SourcesDirectory)/eng/versions/mssql-py-core.version $(ob_outputDirectory)/dist/
+          echo "mssql-py-core version: $(cat $(ob_outputDirectory)/dist/mssql-py-core.version)"
+        displayName: 'Include mssql-py-core version'
+      
       # Verify consolidation
       - bash: |
           echo "=========================================="

OneBranchPipelines/official-release-pipeline.yml

@@ -177,6 +177,14 @@ extends:
                     Write-Host "Symbols: $(if ($symbols) { $symbols.Count } else { 0 }) files"
                     Write-Host "====================================="
               
+              # Step 3.5: Validate mssql-py-core is a stable version (no dev/alpha/beta/rc)
+              - task: PowerShell@2
+                displayName: 'Validate mssql-py-core is a stable version'
+                inputs:
+                  targetType: 'filePath'
+                  filePath: '$(Build.SourcesDirectory)\OneBranchPipelines\scripts\validate-release-versions.ps1'
+                  arguments: '-VersionFile "$(Build.SourcesDirectory)\artifacts\dist\mssql-py-core.version"'
+
               # Step 4: Verify wheel integrity
               - task: PowerShell@2
                 displayName: 'Verify Wheel Integrity'

OneBranchPipelines/scripts/validate-release-versions.ps1

@@ -0,0 +1,49 @@
+# Copyright (c) Microsoft Corporation.
+# Licensed under the MIT License.
+
+<#
+.SYNOPSIS
+    Validates that a version file contains a stable (non-prerelease) version.
+
+.DESCRIPTION
+    Reads a single .version file and rejects any version containing
+    dev, alpha, beta, or rc tags. Intended to gate official releases.
+
+.PARAMETER VersionFile
+    Path to a .version file. Defaults to eng/versions/mssql-py-core.version
+    relative to the repository root.
+
+.EXAMPLE
+    # Run from repo root (uses default path):
+    .\eng\scripts\validate-release-versions.ps1
+
+    # Explicit path:
+    .\eng\scripts\validate-release-versions.ps1 -VersionFile C:\work\mssql-python\eng\versions\mssql-py-core.version
+#>
+
+param(
+    [string]$VersionFile
+)
+
+$ErrorActionPreference = 'Stop'
+
+if (-not $VersionFile) {
+    $repoRoot = (Resolve-Path "$PSScriptRoot\..\..").Path
+    $VersionFile = Join-Path $repoRoot 'eng\versions\mssql-py-core.version'
+}
+
+if (-not (Test-Path $VersionFile)) {
+    Write-Error "Version file not found: $VersionFile"
+    exit 1
+}
+
+$version = (Get-Content $VersionFile -Raw).Trim()
+$name = [System.IO.Path]::GetFileNameWithoutExtension($VersionFile)
+
+if ($version -match '(dev|alpha|beta|rc)') {
+    Write-Host "FAIL: $name version '$version' is a pre-release ($($Matches[1]))" -ForegroundColor Red
+    Write-Error "$name version is pre-release. Official releases require stable versions."
+    exit 1
+}
+
+Write-Host "OK: $name version '$version'" -ForegroundColor Green

OneBranchPipelines/stages/build-linux-single-stage.yml

@@ -104,6 +104,9 @@ stages:
           
           - script: |
               # Determine image based on LINUX_TAG and ARCH
+              # manylinux_2_28 = AlmaLinux 8 (glibc 2.28)
+              # Note: mssql_py_core (built in mssql-rs) requires OpenSSL 3 / glibc 2.34,
+              # but it is pre-built and downloaded from NuGet — not compiled here.
               if [[ "$(LINUX_TAG)" == "musllinux" ]]; then
                 IMAGE="quay.io/pypa/musllinux_1_2_$(ARCH)"
               else
@@ -126,10 +129,10 @@ stages:
                   set -euxo pipefail
                   if command -v dnf >/dev/null 2>&1; then
                     dnf -y update || true
-                    dnf -y install gcc gcc-c++ make cmake unixODBC-devel krb5-libs keyutils-libs ccache || true
+                    dnf -y install gcc gcc-c++ make cmake unixODBC-devel krb5-libs keyutils-libs ccache curl || true
                   elif command -v yum >/dev/null 2>&1; then
                     yum -y update || true
-                    yum -y install gcc gcc-c++ make cmake unixODBC-devel krb5-libs keyutils-libs ccache || true
+                    yum -y install gcc gcc-c++ make cmake unixODBC-devel krb5-libs keyutils-libs ccache curl || true
                   fi
                   gcc --version || true
                   cmake --version || true
@@ -138,7 +141,7 @@ stages:
                 docker exec build-$(LINUX_TAG)-$(ARCH) sh -lc '
                   set -euxo pipefail
                   apk update || true
-                  apk add --no-cache bash build-base cmake unixodbc-dev krb5-libs keyutils-libs ccache || true
+                  apk add --no-cache bash build-base cmake unixodbc-dev krb5-libs keyutils-libs ccache curl || true
                   gcc --version || true
                   cmake --version || true
                 '
@@ -208,6 +211,9 @@ stages:
                     cd /workspace/mssql_python/pybind;
                     bash build.sh;
                     
+                    # Step 3.5: Extract mssql_py_core from NuGet for this Python version
+                    bash /workspace/eng/scripts/install-mssql-py-core.sh;
+                    
                     # Step 4: Build wheel
                     echo "Building wheel package...";
                     cd /workspace;
@@ -273,6 +279,9 @@ stages:
                     cd /workspace/mssql_python/pybind;
                     bash build.sh;
                     
+                    # Step 3.5: Extract mssql_py_core from NuGet for this Python version
+                    bash /workspace/eng/scripts/install-mssql-py-core.sh;
+                    
                     # Step 4: Build wheel
                     echo "Building wheel package...";
                     cd /workspace;

OneBranchPipelines/stages/build-macos-single-stage.yml

@@ -169,6 +169,15 @@ stages:
             env:
               DB_PASSWORD: $(DB_PASSWORD)
           
+          # =========================
+          # MSSQL_PY_CORE INSTALLATION
+          # =========================
+          # Extract mssql_py_core from NuGet into repo root BEFORE testing
+          # Required for bulkcopy tests which use mssql_py_core native bindings
+          - script: |
+              bash $(Build.SourcesDirectory)/eng/scripts/install-mssql-py-core.sh
+            displayName: 'Install mssql_py_core from NuGet'
+          
           # =========================
           # TESTING
           # =========================
@@ -186,6 +195,7 @@ stages:
           # =========================
           # WHEEL BUILD
           # =========================
+
           # Build wheel package from setup.py
           # Wheel filename: mssql_python-X.Y.Z-cp3XX-cp3XX-macosx_XX_X_universal2.whl
           # bdist_wheel = build binary wheel distribution (contains pre-compiled .so)

OneBranchPipelines/stages/build-windows-single-stage.yml

@@ -238,6 +238,17 @@ stages:
             displayName: 'Build PYD for $(targetArch)'
             continueOnError: false
           
+          # =========================
+          # MSSQL_PY_CORE INSTALLATION
+          # =========================
+          # Extract mssql_py_core from NuGet into repo root BEFORE testing
+          # Required for bulkcopy tests which use mssql_py_core native bindings
+          - task: PowerShell@2
+            displayName: 'Install mssql_py_core from NuGet'
+            inputs:
+              targetType: 'filePath'
+              filePath: '$(Build.SourcesDirectory)\eng\scripts\install-mssql-py-core.ps1'
+          
           # =========================
           # TESTING
           # =========================