From 97e248beca840e0c835956500d865a611f6d1ee8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ren=C3=A9=20Schultz=20Madsen?= <rm@microting.com>
Date: Tue, 1 Sep 2026 16:23:52 +0200
Subject: [PATCH] fix(admin): use btn-primary/btn-cancel in confirm-email modal
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

94bba87d7 added the confirm-email dialog with two `<button mat-raised-button>`
in its action row. Material button directives are not part of this app's button
system — the theme override targets `.mat-mdc-text-button`, which Angular
Material 20 never emits — so `scripts/check-button-conventions.js` flags them
and the repo-wide `button-conventions` job has been red on `stable` ever since,
blocking every PR.

Convert both to the house classes, matching the sibling dialogs in the same
folder (remove-user-modal, user-set-password, user-modal): `.btn-cancel` for
the dismissing action and `.btn-primary` for the confirming one. Confirming
email is affirmative, not destructive, so `.btn-primary` is the right slot.

Reorder to the CI-enforced order — cancel first, confirming action rightmost.
The ids are unchanged and no e2e spec in this repo or the sibling plugin repos
references them, so nothing is clicking through the removed
`.mdc-button__label`. The component's stylesheet is empty, and both
`.btn-primary` and `.btn-cancel` are defined globally and re-declared under
`theme-workspace`, so the dialog holds under both themes.

`node scripts/check-button-conventions.js src/app`: 2 violations before,
0 across 174 templates after.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015sXLtgzZU8QL9m84GqMkoJ
---
 .../confirm-email-modal.component.html          | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)

diff --git a/eform-client/src/app/modules/account-management/components/users/confirm-email-modal/confirm-email-modal.component.html b/eform-client/src/app/modules/account-management/components/users/confirm-email-modal/confirm-email-modal.component.html
index d52b52e5c6..851d385f6b 100644
--- a/eform-client/src/app/modules/account-management/components/users/confirm-email-modal/confirm-email-modal.component.html
+++ b/eform-client/src/app/modules/account-management/components/users/confirm-email-modal/confirm-email-modal.component.html
@@ -23,18 +23,17 @@ <h3 mat-dialog-title>{{'Confirm email' | translate}}</h3>
 </div>
 <div mat-dialog-actions class="d-flex flex-row justify-content-end">
   <button
-    mat-raised-button
-    color="primary"
-    id="userConfirmEmailBtn"
-    (click)="confirmEmail()"
-  >
-    {{'Confirm' | translate}}
-  </button>
-  <button
-    mat-raised-button
+    class="btn-cancel"
     id="userConfirmEmailCancelBtn"
     (click)="hide()"
   >
     {{'Cancel' | translate}}
   </button>
+  <button
+    class="btn-primary"
+    id="userConfirmEmailBtn"
+    (click)="confirmEmail()"
+  >
+    {{'Confirm' | translate}}
+  </button>
 </div>