Fix some minor sonar bugs and code smells

Author: javierbrea

LICENSE

@@ -175,5 +175,5 @@
 
    END OF TERMS AND CONDITIONS
 
-   Copyright 2019 Javier Brea
+   Copyright 2019 Javier Brea and contributors
    Copyright 2019 XbyOrange

lib/Cli.js

@@ -1,4 +1,5 @@
 /*
+Copyright 2019 Javier Brea
 Copyright 2019 XbyOrange
 
 Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at
@@ -142,7 +143,9 @@ class Cli {
         if (!input || !input.length) {
           return Promise.resolve(featuresNames);
         }
-        return Promise.resolve(featuresNames.filter(feature => feature.includes(input)));
+        return Promise.resolve(
+          featuresNames.filter(currentFeature => currentFeature.includes(input))
+        );
       }
     });
     this._features.current = feature;

sonar-project.properties

@@ -10,3 +10,7 @@ sonar.coverage.exclusions=test/**/*
 sonar.cpd.exclusions=test/**
 sonar.javascript.lcov.reportPaths=coverage/lcov.info
 sonar.host.url=https://sonarcloud.io
+
+sonar.issue.ignore.multicriteria=j1
+sonar.issue.ignore.multicriteria.j1.ruleKey=javascript:S4144
+sonar.issue.ignore.multicriteria.j1.resourceKey=test/**/*

test/utils/CliRunner.js

@@ -1,4 +1,5 @@
 /*
+Copyright 2019 Javier Brea
 Copyright 2019 XbyOrange
 
 Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at
@@ -116,7 +117,9 @@ module.exports = class CliRunner {
     return this._exitPromise;
   }
 
-  async hasPrinted(data, action, timeOut = 1000) {
+  async hasPrinted(data, inputAction, inputTimeOut = 1000) {
+    let timeOut = inputTimeOut;
+    let action = inputAction;
     if (isNumber(action)) {
       timeOut = action;
       action = null;