Catch server.listen error and reject start promise

Author: javierbrea

lib/Server.js

@@ -127,17 +127,25 @@ class Server {
   }
 
   startServer(resolve, reject) {
-    this._server.listen(this._options, error => {
-      if (error) {
-        tracer.error(`Error starting server: ${error.message}`);
-        this._error = error;
-        reject(error);
-      } else {
-        tracer.info(`Server started and listening at http://localhost:${this._options.port}`);
-        this._error = null;
-        resolve(this);
-      }
-    });
+    try {
+      this._server.listen(this._options, error => {
+        if (error) {
+          tracer.error(`Error starting server: ${error.message}`);
+          this._serverStarting = false;
+          this._serverStarted = false;
+          this._error = error;
+          reject(error);
+        } else {
+          tracer.info(`Server started and listening at http://localhost:${this._options.port}`);
+          this._error = null;
+          this._serverStarting = false;
+          this._serverStarted = true;
+          resolve(this);
+        }
+      });
+    } catch (error) {
+      reject(error);
+    }
   }
 
   get settings() {

test/unit/lib/Server.spec.js

@@ -150,6 +150,19 @@ describe("Server", () => {
   });
 
   describe("start method", () => {
+    it("should reject the promise if an error occurs when calling to server listen method", async () => {
+      const error = new Error("Foo error");
+      libsMocks.stubs.http.createServer.listen.throws(error);
+
+      server = new Server(FOO_FEATURES_PATH);
+
+      try {
+        await server.start();
+      } catch (err) {
+        expect(err).toEqual(error);
+      }
+    });
+
     it("should call to server listen, and resolve the promise when started", async () => {
       libsMocks.stubs.http.createServer.onListen.returns(null);