Fix Programmatic CLI init and start manually

Author: javierbrea

jest.acceptance.config.js

@@ -6,7 +6,7 @@ module.exports = {
   clearMocks: true,
 
   testMatch: ["**/test/acceptance/**/?(*.)+(spec|test).js?(x)"],
-  //testMatch: ["**/test/acceptance/main/web-tutorial-files-watch.spec.js"],
+  //testMatch: ["**/test/acceptance/main/programmatic-cli.spec.js"],
 
   // Indicates whether the coverage information should be collected while executing the test
   collectCoverage: false,

lib/ProgrammaticCli.js

@@ -37,23 +37,28 @@ class ProgrammaticCli {
     );
   }
 
-  async start() {
-    await this._core.init(this._options);
+  async _startCore(cliEnabled) {
     if (!this._coreStarted) {
       this._coreStarted = true;
-      await this._core.start();
+      await this._core.init(this._options);
+      this._core.settings.set("cli", cliEnabled);
+      return this._core.start();
     }
+    return Promise.resolve();
+  }
+
+  async start() {
+    await this._startCore(true);
     if (!this._cliStarted && !this._core.settings.get("cli")) {
       this._core.settings.set("cli", true);
       this._cliStarted = true;
-      this._inquirerCli.start();
+      return this._inquirerCli.start();
     }
+    return Promise.resolve();
   }
 
   async initServer() {
-    await this._core.init(this._options);
-    this._core.settings.set("cli", false);
-    return this._core.start();
+    return this._startCore(false);
   }
 
   stopListeningServerWatch() {

lib/core/server/Server.js

@@ -141,7 +141,7 @@ class Server {
     return Promise.resolve();
   }
 
-  start() {
+  async start() {
     this._initServer();
     return new Promise(this._startServer);
   }

test/acceptance/main/programmatic-cli.spec.js

@@ -176,7 +176,7 @@ describe("programmatic Cli", () => {
     });
   });
 
-  describe("when initializing server manually and start after", () => {
+  describe.only("when initializing server manually and start after", () => {
     it("should start server without cli, then start", async () => {
       expect.assertions(3);
       cli = new CliRunner("init-server.js", {

test/unit/ProgrammaticCli.spec.js

@@ -114,6 +114,12 @@ describe("start method", () => {
       await cli.initServer();
       expect(coreMocks.stubs.instance.start.callCount).toEqual(1);
     });
+
+    it("should start core only once after calling start", async () => {
+      await cli.initServer();
+      await cli.start();
+      expect(coreMocks.stubs.instance.start.callCount).toEqual(1);
+    });
   });
 
   describe("stopListeningServerWatch method", () => {