Fix sonar code smells

Author: javierbrea

test/acceptance/cli/fixtures/autocomplete.js

@@ -47,9 +47,8 @@ const MyCli = class MyCli {
   async displayMainMenu() {
     this._cli.clearScreen();
     this._selectedOption = await this._cli.inquire("main");
-    switch (this._selectedOption) {
-      case "tags":
-        return this.changeTags();
+    if (this._selectedOption === "tags") {
+      return this.changeTags();
     }
   }
 };

test/unit/api/Features.spec.js

@@ -6,6 +6,7 @@ const Features = require("../../../lib/api/Features");
 describe("Features Api", () => {
   let sandbox;
   let routerStubs;
+  let resMock;
   let statusSpy;
   let sendSpy;
 
@@ -15,7 +16,6 @@ describe("Features Api", () => {
       get: sandbox.stub(),
       put: sandbox.stub()
     };
-    routerGetStub = sandbox.stub();
     sandbox.stub(express, "Router").returns(routerStubs);
     statusSpy = sandbox.spy();
     sendSpy = sandbox.spy();

test/unit/api/Settings.spec.js

@@ -8,6 +8,7 @@ const Settings = require("../../../lib/api/Settings");
 describe.only("Settings Api", () => {
   let sandbox;
   let routerStubs;
+  let resMock;
   let statusSpy;
   let sendSpy;
   let settingsMocks;
@@ -19,7 +20,6 @@ describe.only("Settings Api", () => {
       put: sandbox.stub()
     };
     settingsMocks = new SettingsMocks();
-    routerGetStub = sandbox.stub();
     sandbox.stub(express, "Router").returns(routerStubs);
     statusSpy = sandbox.spy();
     sendSpy = sandbox.spy();

test/unit/lib/Server.spec.js

@@ -13,6 +13,7 @@ const Server = require("../../../lib/Server");
 const FOO_FEATURES_PATH = "foo-path";
 
 describe("Server", () => {
+  let server;
   let sandbox;
   let featuresMocks;
   let settingsMocks;

test/unit/lib/middlewares.spec.js

@@ -10,6 +10,7 @@ describe("middlewares", () => {
   let sendSpy;
   let resMock;
   let nextSpy;
+  let headerSpy;
 
   beforeEach(() => {
     sandbox = sinon.createSandbox();