Skip to content

Commit 1786e10

Browse files
authored
Merge pull request #357 from ms-iot/windows_fix
[Windows][melodic-devel] Fix Windows\MSVC build breaks
2 parents 2b96b44 + aedf5fa commit 1786e10

6 files changed

Lines changed: 13 additions & 5 deletions

File tree

CMakeLists.txt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
1-
cmake_minimum_required(VERSION 2.8.3)
1+
cmake_minimum_required(VERSION 3.1.3)
22
project(moveit_tutorials)
33

4-
add_compile_options(-std=c++14)
4+
set(CMAKE_CXX_STANDARD 14)
5+
set(CMAKE_CXX_EXTENSIONS OFF)
56

67
find_package(catkin REQUIRED
78
COMPONENTS

doc/interactivity/CMakeLists.txt

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,12 @@ install(
3737
LIBRARY
3838
DESTINATION
3939
${CATKIN_PACKAGE_LIB_DESTINATION}
40+
ARCHIVE
41+
DESTINATION
42+
${CATKIN_PACKAGE_LIB_DESTINATION}
43+
RUNTIME
44+
DESTINATION
45+
${CATKIN_GLOBAL_BIN_DESTINATION}
4046
)
4147

4248
install(DIRECTORY launch DESTINATION ${CATKIN_PACKAGE_SHARE_DESTINATION})

doc/interactivity/launch/attached_body_tutorial.launch

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<launch>
22

33
<!-- load URDF -->
4-
<param name="robot_description" command="$(find xacro)/xacro.py '$(find panda_description)/robots/panda.urdf.xacro'" />
4+
<param name="robot_description" command="$(find xacro)/xacro '$(find panda_description)/robots/panda.urdf.xacro'" />
55

66
<!-- load SRDF -->
77
<param name="robot_description_semantic" textfile="$(find panda_moveit_config)/config/panda.srdf" />

doc/interactivity/launch/interactivity_tutorial.launch

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<launch>
22

33
<!-- load URDF -->
4-
<param name="robot_description" command="$(find xacro)/xacro.py '$(find panda_description)/robots/panda.urdf.xacro'" />
4+
<param name="robot_description" command="$(find xacro)/xacro '$(find panda_description)/robots/panda.urdf.xacro'" />
55

66
<!-- load SRDF -->
77
<param name="robot_description_semantic" textfile="$(find panda_moveit_config)/config/panda.srdf" />

doc/interactivity/src/interactive_robot.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -271,6 +271,7 @@ bool InteractiveRobot::setGroupPose(const Eigen::Isometry3d& pose)
271271
{
272272
desired_group_end_link_pose_ = pose;
273273
scheduleUpdate();
274+
return true;
274275
}
275276

276277
/* publish robot pose to rviz */

doc/kinematics/src/ros_api_tutorial.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ int main(int argc, char** argv)
6464
while (!service_client.exists())
6565
{
6666
ROS_INFO("Waiting for service");
67-
sleep(1.0);
67+
ros::Duration(1.0).sleep();
6868
}
6969

7070
moveit_msgs::GetPositionIK::Request service_request;

0 commit comments

Comments
 (0)