From 8fc125e9525807df5c34526b8ce0fdc19a0c020c Mon Sep 17 00:00:00 2001 From: Christina Lin Date: Thu, 17 Sep 2026 11:04:20 -0400 Subject: [PATCH] Change restriction type for DISABLE_AND_BLOCK --- src/olympia/scanners/actions.py | 2 +- src/olympia/scanners/tests/test_actions.py | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/olympia/scanners/actions.py b/src/olympia/scanners/actions.py index 93823e0b7430..b29af1f62b38 100644 --- a/src/olympia/scanners/actions.py +++ b/src/olympia/scanners/actions.py @@ -165,7 +165,7 @@ def _disable_and_block(*, version, rule=None): _restrict_future_approvals( version=version, rule=rule, - restriction_type=RESTRICTION_TYPES.ADDON_APPROVAL, + restriction_type=RESTRICTION_TYPES.ADDON_SUBMISSION, ) reject_and_block_addons( [addon], reject_reason=f'scanner rule "{str(rule)[:150]}"' diff --git a/src/olympia/scanners/tests/test_actions.py b/src/olympia/scanners/tests/test_actions.py index 227b084360b5..4b54c9e53941 100644 --- a/src/olympia/scanners/tests/test_actions.py +++ b/src/olympia/scanners/tests/test_actions.py @@ -969,11 +969,11 @@ def do_disable_and_block(self, addon): for author in addon.authors.all(): assert EmailUserRestriction.objects.filter( email_pattern=author.email, - restriction_type=RESTRICTION_TYPES.ADDON_APPROVAL, + restriction_type=RESTRICTION_TYPES.ADDON_SUBMISSION, ).exists() network = IPNetworkUserRestriction.network_from_ip(author.last_login_ip) assert IPNetworkUserRestriction.objects.filter( - network=network, restriction_type=RESTRICTION_TYPES.ADDON_APPROVAL + network=network, restriction_type=RESTRICTION_TYPES.ADDON_SUBMISSION ).exists() def test_disable_and_block(self):