Skip to content

Commit 279ffe0

Browse files
committed
test: remove nonlocal usage
1 parent b5243b1 commit 279ffe0

1 file changed

Lines changed: 20 additions & 24 deletions

File tree

tests/test.py

Lines changed: 20 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -242,7 +242,7 @@ def on_connect():
242242
def test_32_on_mail_callback(self):
243243
logger.debug(' on ')
244244
c = pymoos.comms()
245-
received_mail = False
245+
self.received_mail = False
246246

247247
def on_connect():
248248
logger.debug(' on ')
@@ -251,12 +251,11 @@ def on_connect():
251251

252252
def on_new_mail():
253253
logger.debug(' on ')
254-
nonlocal received_mail
255254
for msg in c.fetch():
256255
logger.debug(' one new mail ')
257256
self.assertTrue(msg.is_name('TEST_CALLBACK_ONMAIL_VAR'))
258257
self.assertEqual(msg.double(), 1)
259-
received_mail = True
258+
self.received_mail = True
260259
logger.debug(' mail processed ')
261260
return True
262261

@@ -268,22 +267,22 @@ def on_new_mail():
268267
time.sleep(1)
269268

270269
self.assertTrue(c.is_registered_for('TEST_CALLBACK_ONMAIL_VAR'))
271-
self.assertFalse(received_mail)
270+
self.assertFalse(self.received_mail)
272271
self.assertTrue(c.notify('TEST_CALLBACK_ONMAIL_VAR', 1, -1))
273272

274273
time.sleep(1)
275274

276-
self.assertTrue(received_mail)
275+
self.assertTrue(self.received_mail)
277276

278277
c.close(True)
279278

280279
def test_33_on_mail_active_queues(self):
281280
logger.debug(' on ')
282281
c = pymoos.comms()
283-
received_mail = False
284-
received_mail_q_v1 = False
285-
received_mail_q_v2 = False
286-
received_mail_q2_v = False
282+
self.received_mail = False
283+
self.received_mail_q_v1 = False
284+
self.received_mail_q_v2 = False
285+
self.received_mail_q2_v = False
287286

288287
def on_connect():
289288
logger.debug(' on ')
@@ -295,32 +294,29 @@ def on_connect():
295294

296295
def on_new_mail_aq():
297296
logger.debug(' on ')
298-
nonlocal received_mail
299297
for msg in c.fetch():
300298
logger.debug(' one new mail = ' + msg.key())
301299
# self.assertTrue(msg.is_name('TEST_ONMAIL_ACTIVE_Q'))
302300
# self.assertEqual(msg.double(), 1)
303-
received_mail = True
301+
self.received_mail = True
304302
logger.debug(' mail processed')
305303
return True
306304

307305
def queue1(msg):
308306
logger.debug(' on ')
309-
nonlocal received_mail_q_v1, received_mail_q_v2
310307
if msg.is_name('TEST_ONQUEUE_VAR1'):
311308
self.assertEqual(msg.double(), 2)
312-
received_mail_q_v1 = True
309+
self.received_mail_q_v1 = True
313310
elif msg.is_name('TEST_ONQUEUE_VAR2'):
314311
self.assertEqual(msg.double(), 3)
315-
received_mail_q_v2 = True
312+
self.received_mail_q_v2 = True
316313
return True
317314

318315
def queue2(msg):
319316
logger.debug(' on ')
320-
nonlocal received_mail_q2_v
321317
if msg.is_name('TEST_ONQUEUE2_VAR'):
322318
self.assertEqual(msg.double(), 4)
323-
received_mail_q2_v = True
319+
self.received_mail_q2_v = True
324320
return True
325321

326322

@@ -341,21 +337,21 @@ def queue2(msg):
341337
self.assertTrue(c.is_registered_for('TEST_ONQUEUE_VAR1'))
342338
self.assertTrue(c.is_registered_for('TEST_ONQUEUE_VAR2'))
343339
self.assertTrue(c.is_registered_for('TEST_ONQUEUE2_VAR'))
344-
self.assertFalse(received_mail)
345-
self.assertFalse(received_mail_q_v1)
346-
self.assertFalse(received_mail_q_v2)
347-
self.assertFalse(received_mail_q2_v)
340+
self.assertFalse(self.received_mail)
341+
self.assertFalse(self.received_mail_q_v1)
342+
self.assertFalse(self.received_mail_q_v2)
343+
self.assertFalse(self.received_mail_q2_v)
348344
self.assertTrue(c.notify('TEST_ONMAIL_ACTIVE_Q', 1))
349345
self.assertTrue(c.notify('TEST_ONQUEUE_VAR1', 2))
350346
self.assertTrue(c.notify('TEST_ONQUEUE_VAR2', 3))
351347
self.assertTrue(c.notify('TEST_ONQUEUE2_VAR', 4))
352348

353349
time.sleep(1)
354350

355-
self.assertTrue(received_mail)
356-
self.assertTrue(received_mail_q_v1)
357-
self.assertTrue(received_mail_q_v2)
358-
self.assertTrue(received_mail_q2_v)
351+
self.assertTrue(self.received_mail)
352+
self.assertTrue(self.received_mail_q_v1)
353+
self.assertTrue(self.received_mail_q_v2)
354+
self.assertTrue(self.received_mail_q2_v)
359355

360356
c.close(True)
361357

0 commit comments

Comments
 (0)