Build Failing due to psalm update

[jarstelfox]

The last passing build of master was running psalm v3.8.5, but after that, builds have been failing psalm v3.11.5+.

I think the best options are either:

1. Put a composer.lock so you can pick when to update psalm in CI
2. Fix the existing issues as you notice them crop up

I don't mind helping out here, just let me know the direction you would like to go.

[mnapoli]

Hi, thank you for raising this!

Putting the composer.lock is indeed not ideal, but I would prefer that here since this is a library that doesn't receive a lot of activity or updates (for good reason, it's pretty stable). So that would be the best to avoid continuous work on this.

If you are able to send a pull request that would be perfect!

[gharlan]

Instead of pushing the composer.lock, you could use an explicit version for vimeo/psalm in composer.json, and update it manually from time to time, or dependabot can create pull requests for increasing the version in composer.json.

[mnapoli]

you could use an explicit version for vimeo/psalm in composer.json

@gharlan that's a good idea!