In this activity, you will all be reviewing a pull request that the course staff has written to add a feature to the calculator project. We haven't written any code in a long time, though, so our skills are kind of rusty... maybe you can help us out.
- When reviewing our code, you must click "Start a review". This way, you can write many comments and then publish them all in one go at the end.
- You must not publish the review until we give the go-ahead. Everybody should publish at the same time to avoid influencing one another.
Write a review of our proposed change to the calculator. When writing your review, you should:
- Aim to push the project forward with your commentary
- Find and suggest fixes for bugs
- Find and suggest fixes for minor code architecture problems
- Advocate for best practices as you have learned them in this course
- Be clear, direct, and kind
You should not:
- Gatekeep development of the project
- Be rude or hostile
- Assume our code is correct just because we are the course staff
- Assume your comment or question is insignificant
Have fun.
- Navigate to https://github.com/neu-cs4530-fall2024/Week5-CodeReviewActivity and find the open pull request.
- Go to the "Conversation" tab (the default) and read the summary.
- Go to the "Files changed" tab and click any + sign next to a changed line to start writing a comment.
- Click "Start a review".
- Write as many comments as seems reasonable, complete, and helpful.
- When we give the signal, publish your review.
- Pay attention as we debate the merits of your reviews.
Make sure you publish your review, and only when we tell you to. After submitting your review, please take a screenshot of your comments and upload it to Gradescope.