Skip to content

Commit 8b2dd9d

Browse files
small1julien-nc
authored andcommitted
Remove web ui setting and rename occ command to --entraid-group-names, update readme
Signed-off-by: Johan Bernhardsson <johan.bernhardsson@redpill-linpro.com>
1 parent c9fbf43 commit 8b2dd9d

4 files changed

Lines changed: 3 additions & 12 deletions

File tree

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -435,10 +435,10 @@ The following formats are supported for the groups claim:
435435

436436
If using EntraID an option to turn on group name lookups via Microsoft Graph. It will loop through all guid a user has and store the names of the groups in Nextcloud.
437437

438-
This can be done in the graphical settings for the provider by toggling "Fetch group names from Microsoft Graph" or with the occ command to create/update providers:
438+
This can be done in the graphical settings for the provider by with the occ command to create/update providers:
439439

440440
```
441-
sudo -u www-data php occ user_oidc:provider demoprovider --entraid=1
441+
sudo -u www-data php occ user_oidc:provider demoprovider --entraid-group-names=1
442442
```
443443

444444
### Disable audience and azp checks

lib/Command/UpsertProvider.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ class UpsertProvider extends Base {
155155
'shortcut' => null, 'mode' => InputOption::VALUE_REQUIRED, 'setting_key' => ProviderService::SETTING_MAPPING_GROUPS,
156156
'description' => 'Attribute mapping of the groups',
157157
],
158-
'entraid' => [
158+
'entraid-group-names' => [
159159
'shortcut' => null, 'mode' => InputOption::VALUE_REQUIRED, 'setting_key' => ProviderService::SETTING_AZURE_GROUP_NAMES,
160160
'description' => 'Turn on usage of mapping guid to names with Microsoft Graph. 1 to enable, 0 to disable (default)',
161161
],

src/components/AdminSettings.vue

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,6 @@ export default {
203203
providerBasedId: false,
204204
groupProvisioning: false,
205205
sendIdTokenHint: true,
206-
azureGroupNames: false,
207206
},
208207
},
209208
showNewProvider: false,

src/components/SettingsForm.vue

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -300,14 +300,6 @@
300300
<p class="settings-hint">
301301
{{ t('user_oidc', 'Only groups matching the whitelist regex will be created, updated and deleted by the group claim. For example: {regex} allows all groups which ID starts with {substr}', { regex: '/^blue/', substr: 'blue' }) }}
302302
</p>
303-
<NcCheckboxRadioSwitch
304-
v-model="localProvider.settings.azureGroupNames"
305-
wrapper-element="div">
306-
{{ t('user_oidc', 'Fetch group names from Microsoft Graph') }}
307-
</NcCheckboxRadioSwitch>
308-
<p class="settings-hint">
309-
{{ t('user_oidc', 'If the provider is Azure its possible to connect to Microsoft Graph to fetch group names') }}
310-
</p>
311303
<NcCheckboxRadioSwitch
312304
v-model="localProvider.settings.restrictLoginToGroups"
313305
wrapper-element="div">

0 commit comments

Comments
 (0)