make the user backend a ISetDisplayNameBackend one, this fixes incorrect photo in system addressbook vcard and simplifies the provisioning service

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>

Author: julien-nc

lib/Service/ProvisioningService.php

@@ -9,7 +9,6 @@
 
 use InvalidArgumentException;
 use OC\Accounts\AccountManager;
-use OCA\UserOIDC\AppInfo\Application;
 use OCA\UserOIDC\Db\UserMapper;
 use OCA\UserOIDC\Event\AttributeMappedEvent;
 use OCP\Accounts\IAccountManager;
@@ -176,29 +175,10 @@ public function provisionUser(string $tokenUserId, int $providerId, object $idTo
 		if ($event->hasValue() && $event->getValue() !== null && $event->getValue() !== '') {
 			$oidcGssUserData[$displaynameAttribute] = $event->getValue();
 			$newDisplayName = $event->getValue();
-			if ($existingLocalUser === null) {
-				$oldDisplayName = $backendUser->getDisplayName();
-				if ($newDisplayName !== $oldDisplayName) {
-					$backendUser->setDisplayName($newDisplayName);
-					$this->userMapper->update($backendUser);
-				}
-				// 2 reasons why we should update the display name: It does not match the one
-				// - of our backend
-				// - returned by the user manager (outdated one before the fix in https://github.com/nextcloud/user_oidc/pull/530)
-				if ($newDisplayName !== $oldDisplayName || $newDisplayName !== $user->getDisplayName()) {
-					$this->eventDispatcher->dispatchTyped(new UserChangedEvent($user, 'displayName', $newDisplayName, $oldDisplayName));
-				}
-			} else {
-				$oldDisplayName = $user->getDisplayName();
-				if ($newDisplayName !== $oldDisplayName) {
-					$user->setDisplayName($newDisplayName);
-					if ($user->getBackendClassName() === Application::APP_ID) {
-						$backendUser = $this->userMapper->getOrCreate($providerId, $user->getUID());
-						$backendUser->setDisplayName($newDisplayName);
-						$this->userMapper->update($backendUser);
-					}
-					$this->eventDispatcher->dispatchTyped(new UserChangedEvent($user, 'displayName', $newDisplayName, $oldDisplayName));
-				}
+			$oldDisplayName = $user->getDisplayName();
+			if ($newDisplayName !== $oldDisplayName) {
+				$user->setDisplayName($newDisplayName);
+				$this->eventDispatcher->dispatchTyped(new UserChangedEvent($user, 'displayName', $newDisplayName, $oldDisplayName));
 			}
 		}
 

lib/User/Backend.php

@@ -37,9 +37,10 @@
 use OCP\User\Backend\ICustomLogout;
 use OCP\User\Backend\IGetDisplayNameBackend;
 use OCP\User\Backend\IPasswordConfirmationBackend;
+use OCP\User\Backend\ISetDisplayNameBackend;
 use Psr\Log\LoggerInterface;
 
-class Backend extends ABackend implements IPasswordConfirmationBackend, IGetDisplayNameBackend, IApacheBackend, ICustomLogout, ICountUsersBackend {
+class Backend extends ABackend implements IPasswordConfirmationBackend, IGetDisplayNameBackend, ISetDisplayNameBackend, IApacheBackend, ICustomLogout, ICountUsersBackend {
 	private $tokenValidators = [
 		SelfEncodedValidator::class,
 		UserInfoValidator::class,
@@ -91,6 +92,17 @@ public function userExists($uid): bool {
 		return $this->userMapper->userExists($uid);
 	}
 
+	public function setDisplayName(string $uid, string $displayName): bool {
+		try {
+			$user = $this->userMapper->getUser($uid);
+			$user->setDisplayName($displayName);
+			$this->userMapper->update($user);
+			return true;
+		} catch (DoesNotExistException $e) {
+			return false;
+		}
+	}
+
 	public function getDisplayName($uid): string {
 		try {
 			$user = $this->userMapper->getUser($uid);