Skip to content

BaseballHelm: Compact the public player profile mobile hero and fix shared-link navigation #482

Description

@njrini99-code

Problem

The public profile uses a tall decorative hero and absolute controls that are not safe-area aware; the back affordance is hard-wired to Discover and the hero exposes two competing coach actions.

Evidence

  • src/app/baseball/(public)/player/[id]/PlayerProfileClient.tsx (lines 231-265): h-52 banner with absolute top-4 left-4 back link to /baseball/dashboard/discover
  • (lines 268-297): simultaneous "Add to Watchlist" and "Message" buttons in the hero overlay
  • (lines 309-313): w-32 h-32 avatar on mobile

Why it matters

Shared recruiting links opened on a phone bury stats/videos below a ~200px+ hero, notch devices can clip controls, and non-Discover entry paths get a misleading back target.

Acceptance criteria

  • Mobile hero height is ≤ ~120px; primary player identity is visible without scrolling on a 390×844 viewport.
  • Top controls respect env(safe-area-inset-top) (or safe-area-top utility).
  • Back/history behavior uses browser history or context-aware fallback, not a fixed Discover URL.
  • Coach actions collapse to one primary CTA with secondary actions in overflow on <md.

Metadata

Metadata

Assignees

No one assigned

    Labels

    baseballBaseballHelmbugIncorrect behavior or regressionmobileCapacitor/iOS/mobile UI

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions