Latest CITGM results

[RafaelGSS]

• running - main - https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3299/testReport/
• 15 failures v20.x - https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3297/testReport/ (related nan tests fail on three platforms with Node.js 20.x #996)
• running - v18.x - https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3298/testReport/

Let's use this issue to list failing modules and take action such as removing offending modules, skip specific arches and so on

@nodejs/citgm

[ljharb]

tape failed on rhel8-ppc64le due to a timeout; i suspect with a longer timeout it'd pass.

[alfonsograziano]

I just had a nice chat with @RafaelGSS. Will look into it :)

[alfonsograziano]

Regarding this test fail.
On my machine works fine with these specifications:

• Node v20.8 (as in the CI run)
• underscore-v1.13.6 (as in the CI run)
• macOs version 13.6

Command run: citgm underscore@1.13.6
The tests are not flacky on this package.

[alfonsograziano]

All the issues regarding macOS are not reproducible for me locally. I'm using the correct Node version and the correct package version, the tests are not failing on my machine. @nodejs/build

[RafaelGSS]

Let's wait v18.x and main to see if the same happens for these versions. But, I guess that's something related to our machines.

[Trott]

The failures on three platforms for nan already has an issue (#996). It would be great if someone could figure that one out. (I haven't looked and don't have the right expertise probably anyway.)

EDIT: Oh, I see @RafaelGSS already linked to it in the description. I'd love to see someone get to the bottom of that one.

[Trott]

The macOS failures have a PR that might be worth landing just to bypass things for straightforward JavaScript modules.

#971

[Trott]

tape failed on rhel8-ppc64le due to a timeout; i suspect with a longer timeout it'd pass.

@ljharb Is it possible to pass a longer timeout value via the command line? Something along the lines of npm run tests-only -- --timeout=99999? If so, it would just be a matter of updating line 483 of lookup.json.

citgm/lib/lookup.json

Line 483 in cd1b288

"scripts": ["tests-only"],

[alfonsograziano]

Is really interesting to notice that in the last run on main there are no issues over macOS even without the skip applied, but on v18.18 there are 6 errors.

I managed to reproduce the issue over pino@8.15.3 and also the multer issue. The multer one is flaky on my machine, here is the PR to fix it

[alfonsograziano]

@ljharb probably also semver failed due to a timeout. Shall we try to increase it or set it as flaky due to tests timeout?

[ruyadorno]

Please keep the max timeout to a reasonable amount. We don't want to end up with a citgm run that takes forever to timeout when something got stuck in the test.

[ruyadorno]

I managed to reproduce the issue over pino@8.15.3 and also the multer issue. The multer one is flaky on my machine, here is the PR to fix it

While that's a good short-term solution to the problem, an actual fix should hopefully land in either multer or node so that it stop failing on macos. In these cases please open an issue pinging the maintainer - you can find it by browsing lookup.json e.g:

citgm/lib/lookup.json

Lines 337 to 341 in cd1b288

	"multer": {
	"prefix": "v",
	"skip": "win32",
	"maintainers": "linusu"
	},

Here's an example of an issue pinging the maintainer of a package for help: #988. Keep in mind you might be able to post more info, since you're able to reproduce in your machine you might be able to add some helpful logs or maybe test which combinations of package version + node version it fails vs succeeds, etc.

Thanks for the help @alfonsograziano it's really appreciated! 🙏

[alfonsograziano]

Here are a few issues/PRs open now to fix these issues:

• chore: increasing timeout for ava #1003
• lookup: will make multer flaky on macOS #998
• multer@v1.4.5-lts.1 failures #999

[RafaelGSS]

After merging both PRs:

• main CITGM https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3307/