Skip to content

Commit df8176e

Browse files
committed
Fix mapping for char(x)
char(x) were wrongly getting scaffolded as char instead of string. Fixes #370
1 parent 0b0531e commit df8176e

3 files changed

Lines changed: 3 additions & 2 deletions

File tree

src/EFCore.PG/Storage/Internal/NpgsqlEFTypeMapper.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,7 @@ void AddCustomizedMappings()
8181
// Mappings where we need literal string generation
8282
_baseClrMappings[typeof(string)] = _storeTypeMappings["text"] = new NpgsqlStringTypeMapping("text", NpgsqlDbType.Text);
8383
_storeTypeMappings["varchar"] = new NpgsqlStringTypeMapping("varchar", NpgsqlDbType.Varchar);
84+
_storeTypeMappings["char"] = new NpgsqlStringTypeMapping("char", NpgsqlDbType.Char);
8485
_storeTypeMappings["citext"] = new NpgsqlStringTypeMapping("citext", NpgsqlDbType.Citext);
8586
_storeTypeMappings["json"] = new NpgsqlStringTypeMapping("json", NpgsqlDbType.Json);
8687
_storeTypeMappings["jsonb"] = new NpgsqlStringTypeMapping("jsonb", NpgsqlDbType.Jsonb);

test/EFCore.PG.Design.FunctionalTests/ReverseEngineering/Expected/AllFluentApi/AllDataTypes.expected

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ namespace E2ETest.Namespace
1414
public decimal DecimalColumn { get; set; }
1515
public decimal NumericColumn { get; set; }
1616
public decimal MoneyColumn { get; set; }
17-
public char? CharColumn { get; set; }
17+
public string CharColumn { get; set; }
1818
public string TextColumn { get; set; }
1919
public string VarcharColumn { get; set; }
2020
public DateTime DateColumn { get; set; }

test/EFCore.PG.Design.FunctionalTests/ReverseEngineering/Expected/Attributes/AllDataTypes.expected

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ namespace E2ETest.Namespace
2626
[Column("moneyColumn", TypeName = "money")]
2727
public decimal MoneyColumn { get; set; }
2828
[Column("charColumn", TypeName = "char(1)")]
29-
public char? CharColumn { get; set; }
29+
public string CharColumn { get; set; }
3030
[Column("textColumn")]
3131
public string TextColumn { get; set; }
3232
[Column("varcharColumn", TypeName = "varchar")]

0 commit comments

Comments
 (0)