From 5d3cc04bdf9f0f90e1d1bcd315f74eb3e0d1aa86 Mon Sep 17 00:00:00 2001 From: Martijn Laarman Date: Wed, 2 Sep 2026 20:31:15 +0200 Subject: [PATCH] Fix nuget push retry loop hanging forever on GitHub Packages --no-symbols is a boolean switch in dotnet nuget push and takes no value; the trailing "true" was parsed as a second package-path argument, which doesn't exist ("error: File does not exist (true)."). Every retry in the until loop hit this same parse error, so the step never exited and the job ran until it was cancelled. Also fixes the same typo in the nuget.org release step, which would have hit the same bug on the next tagged release. Co-Authored-By: Claude Co-authored-by: Cursor --- .github/workflows/ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 60e18bd..008717c 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -114,7 +114,7 @@ jobs: if: github.event_name == 'push' && startswith(github.ref, 'refs/heads') shell: bash run: | - until dotnet nuget push build/output/*.nupkg -k ${{secrets.GITHUB_TOKEN}} --skip-duplicate --no-symbols true; do echo "Retrying"; sleep 1; done; + until dotnet nuget push build/output/*.nupkg -k ${{secrets.GITHUB_TOKEN}} --skip-duplicate --no-symbols; do echo "Retrying"; sleep 1; done; # ghcr.io/nullean/assembly-differ, matching curb's own tagging: "edge" on every push, plus # "latest" and the semver when this push is an exact release tag — see @@ -139,6 +139,6 @@ jobs: if: github.event_name == 'push' && startswith(github.ref, 'refs/tags') name: Create or update release for tag on github - - run: dotnet nuget push 'build/output/*.nupkg' -k ${{secrets.NUGET_ORG_API_KEY}} -s https://api.nuget.org/v3/index.json --skip-duplicate --no-symbols true + - run: dotnet nuget push 'build/output/*.nupkg' -k ${{secrets.NUGET_ORG_API_KEY}} -s https://api.nuget.org/v3/index.json --skip-duplicate --no-symbols name: release to nuget.org if: github.event_name == 'push' && startswith(github.ref, 'refs/tags')