exposed connect/read/... timeout parameters

Author: hhund

codex-process-data-transfer/src/main/java/de/netzwerk_universitaetsmedizin/codex/processes/data_transfer/client/FttpClientFactory.java

@@ -89,18 +89,27 @@ public void testConnection()
 	private final String fttpStudy;
 	private final String fttpTarget;
 
+	private final int connectTimeout;
+	private final int socketTimeout;
+	private final int connectionRequestTimeout;
+
 	private final String proxySchemeHostPort;
 	private final String proxyUsername;
 	private final String proxyPassword;
 
-	public FttpClientFactory(Path trustStorePath, Path certificatePath, Path privateKeyPath,
-			String fttpBasicAuthUsername, String fttpBasicAuthPassword, String fttpServerBase, String fttpApiKey,
-			String fttpStudy, String fttpTarget, String proxySchemeHostPort, String proxyUsername, String proxyPassword)
+	public FttpClientFactory(Path trustStorePath, Path certificatePath, Path privateKeyPath, int connectTimeout,
+			int socketTimeout, int connectionRequestTimeout, String fttpBasicAuthUsername, String fttpBasicAuthPassword,
+			String fttpServerBase, String fttpApiKey, String fttpStudy, String fttpTarget, String proxySchemeHostPort,
+			String proxyUsername, String proxyPassword)
 	{
 		this.trustStorePath = trustStorePath;
 		this.certificatePath = certificatePath;
 		this.privateKeyPath = privateKeyPath;
 
+		this.connectTimeout = connectTimeout;
+		this.socketTimeout = socketTimeout;
+		this.connectionRequestTimeout = connectionRequestTimeout;
+
 		this.fttpBasicAuthUsername = fttpBasicAuthUsername;
 		this.fttpBasicAuthPassword = fttpBasicAuthPassword;
 
@@ -155,8 +164,9 @@ protected FttpClient createFttpClient()
 		logger.debug("Creating key-store from {} and {}", certificatePath.toString(), privateKeyPath.toString());
 		KeyStore keyStore = readKeyStore(certificatePath, privateKeyPath, keyStorePassword);
 
-		return new FttpClientImpl(trustStore, keyStore, keyStorePassword, fttpBasicAuthUsername, fttpBasicAuthPassword,
-				fttpServerBase, fttpApiKey, fttpStudy, fttpTarget, proxySchemeHostPort, proxyUsername, proxyPassword);
+		return new FttpClientImpl(trustStore, keyStore, keyStorePassword, connectTimeout, socketTimeout,
+				connectionRequestTimeout, fttpBasicAuthUsername, fttpBasicAuthPassword, fttpServerBase, fttpApiKey,
+				fttpStudy, fttpTarget, proxySchemeHostPort, proxyUsername, proxyPassword);
 	}
 
 	private KeyStore readTrustStore(Path trustPath)

codex-process-data-transfer/src/main/java/de/netzwerk_universitaetsmedizin/codex/processes/data_transfer/client/FttpClientImpl.java

@@ -49,15 +49,14 @@ public class FttpClientImpl implements FttpClient, InitializingBean
 	private final String proxyUsername;
 	private final String proxyPassword;
 
-	public FttpClientImpl(KeyStore trustStore, KeyStore keyStore, char[] keyStorePassword, String fttpBasicAuthUsername,
-			String fttpBasicAuthPassword, String fttpServerBase, String fttpApiKey, String fttpStudy, String fttpTarget,
+	public FttpClientImpl(KeyStore trustStore, KeyStore keyStore, char[] keyStorePassword, int connectTimeout,
+			int socketTimeout, int connectionRequestTimeout, String fttpBasicAuthUsername, String fttpBasicAuthPassword,
+			String fttpServerBase, String fttpApiKey, String fttpStudy, String fttpTarget,
+
 			String proxySchemeHostPort, String proxyUsername, String proxyPassword)
 	{
-		this.proxySchemeHostPort = proxySchemeHostPort;
-		this.proxyUsername = proxyUsername;
-		this.proxyPassword = proxyPassword;
-
-		clientFactory = createClientFactory(trustStore, keyStore, keyStorePassword);
+		clientFactory = createClientFactory(trustStore, keyStore, keyStorePassword, connectTimeout, socketTimeout,
+				connectionRequestTimeout);
 
 		this.fttpServerBase = fttpServerBase;
 		this.fttpBasicAuthUsername = fttpBasicAuthUsername;
@@ -66,10 +65,14 @@ public FttpClientImpl(KeyStore trustStore, KeyStore keyStore, char[] keyStorePas
 		this.fttpApiKey = fttpApiKey;
 		this.fttpStudy = fttpStudy;
 		this.fttpTarget = fttpTarget;
+
+		this.proxySchemeHostPort = proxySchemeHostPort;
+		this.proxyUsername = proxyUsername;
+		this.proxyPassword = proxyPassword;
 	}
 
 	protected ApacheRestfulClientFactoryWithTlsConfig createClientFactory(KeyStore trustStore, KeyStore keyStore,
-			char[] keyStorePassword)
+			char[] keyStorePassword, int connectTimeout, int socketTimeout, int connectionRequestTimeout)
 	{
 		Objects.requireNonNull(trustStore, "trustStore");
 		Objects.requireNonNull(keyStore, "keyStore");
@@ -81,6 +84,10 @@ protected ApacheRestfulClientFactoryWithTlsConfig createClientFactory(KeyStore t
 		hapiClientFactory.setServerValidationMode(ServerValidationModeEnum.NEVER);
 		configureProxy(hapiClientFactory);
 
+		hapiClientFactory.setConnectTimeout(connectTimeout);
+		hapiClientFactory.setSocketTimeout(socketTimeout);
+		hapiClientFactory.setConnectionRequestTimeout(connectionRequestTimeout);
+
 		fhirContext.setRestfulClientFactory(hapiClientFactory);
 		return hapiClientFactory;
 	}

codex-process-data-transfer/src/main/java/de/netzwerk_universitaetsmedizin/codex/processes/data_transfer/client/HapiFhirClientFactory.java

@@ -61,9 +61,16 @@ public class HapiFhirClientFactory
 	 *            may be <code>null</code>
 	 * @param bearerToken
 	 *            may be <code>null</code>
+	 * @param connectTimeout
+	 *            >= -1, -1: system default, 0: infinity, >0: timeout in ms
+	 * @param socketTimeout
+	 *            >= -1, -1: system default, 0: infinity, >0: timeout in ms
+	 * @param connectionRequestTimeout
+	 *            >= -1, -1: system default, 0: infinity, >0: timeout in ms
 	 */
 	public HapiFhirClientFactory(FhirContext fhirContext, String serverBase, String basicAuthUsername,
-			String basicAuthPassword, String bearerToken)
+			String basicAuthPassword, String bearerToken, int connectTimeout, int socketTimeout,
+			int connectionRequestTimeout)
 	{
 		if (fhirContext != null)
 			this.fhirContext = fhirContext;
@@ -79,6 +86,9 @@ public HapiFhirClientFactory(FhirContext fhirContext, String serverBase, String
 		{
 			clientFactory = new ApacheRestfulClientFactory(this.fhirContext);
 			clientFactory.setServerValidationMode(ServerValidationModeEnum.NEVER);
+			clientFactory.setConnectTimeout(connectTimeout);
+			clientFactory.setSocketTimeout(socketTimeout);
+			clientFactory.setConnectionRequestTimeout(connectionRequestTimeout);
 		}
 		else
 			clientFactory = null;