Skip to content
This repository was archived by the owner on Oct 6, 2025. It is now read-only.

Commit d19706c

Browse files
committed
Merge remote-tracking branch
'origin/issues/93_validation_startup_log_levels' into develop
2 parents 3bc08dd + f5c29d3 commit d19706c

6 files changed

Lines changed: 13 additions & 11 deletions

File tree

codex-process-data-transfer/src/main/java/de/netzwerk_universitaetsmedizin/codex/processes/data_transfer/validation/ValidationPackageManagerImpl.java

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -232,16 +232,18 @@ private void expandExternal(List<ValueSet> expandedValueSets, ValueSet v)
232232
}
233233
catch (WebApplicationException e)
234234
{
235-
logger.error("Error while expanding ValueSet {}|{}: {} - {}", v.getUrl(), v.getVersion(),
236-
e.getClass().getName(), e.getMessage());
235+
logger.warn(
236+
"Error while expanding ValueSet {}|{} externally, this may result in incomplete validation: {} - {}",
237+
v.getUrl(), v.getVersion(), e.getClass().getName(), e.getMessage());
237238
getOutcome(e).ifPresent(m -> logger.debug("Expansion error response: {}", m));
238239
logger.debug("ValueSet with error while expanding: {}",
239240
fhirContext.newJsonParser().encodeResourceToString(v));
240241
}
241242
catch (Exception e)
242243
{
243-
logger.error("Error while expanding ValueSet {}|{}: {} - {}", v.getUrl(), v.getVersion(),
244-
e.getClass().getName(), e.getMessage());
244+
logger.warn(
245+
"Error while expanding ValueSet {}|{} externally, this may result in incomplete validation: {} - {}",
246+
v.getUrl(), v.getVersion(), e.getClass().getName(), e.getMessage());
245247
logger.debug("ValueSet with error while expanding: {}",
246248
fhirContext.newJsonParser().encodeResourceToString(v));
247249
}
@@ -254,15 +256,15 @@ private void expandInternal(List<ValueSet> expandedValueSets, ValueSetExpander e
254256
ValueSetExpansionOutcome expansion = expander.expand(v);
255257

256258
if (expansion.getError() != null)
257-
logger.warn("Error while expanding ValueSet {}|{}: {}", v.getUrl(), v.getVersion(),
259+
logger.warn("Error while expanding ValueSet {}|{} internally: {}", v.getUrl(), v.getVersion(),
258260
expansion.getError());
259261
else
260262
expandedValueSets.add(expansion.getValueset());
261263
}
262264
catch (Exception e)
263265
{
264266
logger.info(
265-
"Error while expanding ValueSet {}|{}: {} - {}, trying to expand via external terminology server next",
267+
"Error while expanding ValueSet {}|{} internally: {} - {}, trying to expand via external terminology server next",
266268
v.getUrl(), v.getVersion(), e.getClass().getName(), e.getMessage());
267269

268270
expandExternal(expandedValueSets, v);

codex-process-data-transfer/src/main/java/de/netzwerk_universitaetsmedizin/codex/processes/data_transfer/validation/ValidationPackageWithDepedencies.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -255,7 +255,7 @@ private void logMissingValueSets(Set<String> neededValueSets, List<ValueSet> fou
255255
if (!missingValueSets.isEmpty())
256256
{
257257
logger.warn(
258-
"The following ValueSet are required for validation but could not be found in validation package {}|{} or its dependencies: {}",
258+
"The following ValueSet are required for validation but could not be found in validation package {}|{} or its dependencies, this may result in incomplete valdidation: {}",
259259
getName(), getVersion(), missingValueSets);
260260
}
261261
}

codex-process-data-transfer/src/main/java/de/netzwerk_universitaetsmedizin/codex/processes/data_transfer/validation/structure_definition/ClosedTypeSlicingRemover.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ public StructureDefinition modify(StructureDefinition sd)
2727
ElementDefinitionSlicingDiscriminatorComponent discriminator = slicing.getDiscriminator().get(0);
2828
if (DiscriminatorType.TYPE.equals(discriminator.getType()) && "$this".equals(discriminator.getPath()))
2929
{
30-
logger.warn(
30+
logger.info(
3131
"Removing Type slicing with slicing.rules != closed from validation rule with id {} in StructureDefinition {}|{}",
3232
e.getId(), sd.getUrl(), sd.getVersion());
3333

codex-process-data-transfer/src/main/java/de/netzwerk_universitaetsmedizin/codex/processes/data_transfer/validation/structure_definition/IdentifierRemover.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ public StructureDefinition modify(StructureDefinition sd)
3535

3636
if (filteredRules.size() < sd.getDifferential().getElement().size())
3737
{
38-
logger.warn("Removing validation rules with ids {} from StructureDefinition {}|{}",
38+
logger.info("Removing validation rules with ids {} from StructureDefinition {}|{}",
3939
sd.getDifferential().getElement().stream().filter(toRemove).map(ElementDefinition::getId)
4040
.collect(Collectors.joining(", ", "[", "]")),
4141
sd.getUrl(), sd.getVersion());

codex-process-data-transfer/src/main/java/de/netzwerk_universitaetsmedizin/codex/processes/data_transfer/validation/structure_definition/SliceMinFixer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ public StructureDefinition modify(StructureDefinition sd)
2727
.anyMatch(e1 -> Objects.equals(e.getPath(), e1.getPath()) && e1.hasSlicing()))
2828
.forEach(e ->
2929
{
30-
logger.warn("Adding min=0 to rule with id {} in StructureDefinition {}|{}", e.getId(), sd.getUrl(),
30+
logger.info("Adding min=0 to rule with id {} in StructureDefinition {}|{}", e.getId(), sd.getUrl(),
3131
sd.getVersion(), sd.getBaseDefinition(), sd.getDifferential().getElement().stream()
3232
.anyMatch(e1 -> Objects.equals(e.getPath(), e1.getPath()) && e1.hasSlicing()));
3333
e.setMin(0);

codex-process-data-transfer/src/main/java/de/netzwerk_universitaetsmedizin/codex/processes/data_transfer/validation/value_set/MissingEntriesIncluder.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ public ValueSet modifyPostExpansion(ValueSet vsWithComposition, ValueSet vsWithE
3838
if (!expandedEntries.contains(toEntry(system, concept.getCode()))
3939
&& !expandedEntries.contains(toEntry(system, concept.getCode())))
4040
{
41-
logger.warn(
41+
logger.info(
4242
"Adding missing concept to ValueSet {}|{}: system: '{}', version: '{}', code: '{}', display: '{}'",
4343
vsWithExpansion.getUrl(), vsWithExpansion.getVersion(), system, version,
4444
concept.getCode(), concept.getDisplay());

0 commit comments

Comments
 (0)