Skip to content

Commit b26af7b

Browse files
committed
Mon Jan 6 06:21:29 UTC 2020 Chad Elliott <elliottc@objectcomputing.com>
1 parent 5d680f2 commit b26af7b

2 files changed

Lines changed: 14 additions & 1 deletion

File tree

ChangeLog

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,11 @@
1+
Mon Jan 6 06:21:29 UTC 2020 Chad Elliott <elliottc@objectcomputing.com>
2+
3+
* modules/ProjectCreator.pm:
4+
5+
Make a copy of the flag override hash when connecting it to a
6+
file so that we do not inadvertantly modify multiple flag overrides
7+
when modifying flag overrides for a single file.
8+
19
Mon Jul 1 18:35:43 UTC 2019 Chad Elliott <elliottc@objectcomputing.com>
210

311
* modules/TemplateParser.pm:

modules/ProjectCreator.pm

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1429,7 +1429,12 @@ sub process_component_line {
14291429
my $over = $self->{'flag_overrides'}->{$tag};
14301430
if (defined $over) {
14311431
foreach my $file (@files) {
1432-
$$over{$file} = $flags;
1432+
## We are giving these flag overrides to multiple files. Since
1433+
## $flags is a hash reference, we need to make a copy so that
1434+
## modifying one of these files flag overrides doesn't modify
1435+
## all of them.
1436+
my %copy = %$flags;
1437+
$$over{$file} = \%copy;
14331438
}
14341439
}
14351440

0 commit comments

Comments
 (0)